Repository navigation
Conversation
… droping non-image-files Signed-off-by: Janina Hiob <user-y5tppt@dev.dataport.de> Assisted-by: GPT-5.3-Codex
39c0c36 to
dcb9afa
Compare
|
Thanks a lot for the contribution @hiobjan. I wholehearted agree that it's confusing to have different representations of attachments in Text and that it's not possible to toggle between them. I see that your PR improves the UX when a user drags and drops a file into the editor and expects a file preview. On the other hand, this means that inserting attachments via drag and drop behaves differently than inserting attachments via menubar, which is something we should avoid in my opinion. I'd prefer to first discuss this topic in and issue and decide on a way forward, ideally together with the design team. I opened #8948 and would be curious about your thoughts there. I'll therefore close this PR for now. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
📝 Summary
Problem / Usecase
When adding a file to a text via drag and drop, no preview window is generated. It also isn't possible to optionally enable the preview.
Solution
Use the same behaviour/code as by inserting via smartpicker. I didnt change the behaviour of images, because the attachment-view is better than the attachment-preview. #8774
🖼️ Screenshots
🏚️ Before


🏡 After
🚧 TODO
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)🤖 AI (if applicable)