Skip to content

fix(table): replace alert() with showWarning() for nested table paste - #8795

Merged
mejo- merged 1 commit into
nextcloud:mainfrom
omnizs38:fix/replace-alert-with-showwarning-in-tablecell
Jun 30, 2026
Merged

mejo- merged 1 commit into
nextcloud:mainfrom
omnizs38:fix/replace-alert-with-showwarning-in-tablecell

Conversation

@omnizs38

@omnizs38 omnizs38 commented Jun 29, 2026 •

Copy link
Copy Markdown
Contributor

📝 Summary

  • Resolves:

Replaces the blocking window.alert() dialog with a non-blocking showWarning() toast notification when a user pastes a table into a table cell (nested tables are not supported in this editor).

Before: A browser-native alert() dialog would pop up, blocking all UI interaction until dismissed. It was unstyled and confusing.
After: A styled Nextcloud toast notification using showWarning() from @nextcloud/dialogs, consistent with other warnings throughout the app (e.g., permission changes in Editor.vue).

🖼️ Screenshots

🏚️ Before 🏡 After
N/A N/A

Not applicable.

🚧 TODO

  • ...

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests — all 14 table unit tests pass
  • Documentation (README or documentation) has been updated or is not required

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI tools
  • The AI-generated content was reviewed, comprehended and tested by a human

@mejo- mejo- left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works well. Thanks a lot for the contribution 🙏

@mejo-
mejo- merged commit 532ce31 into nextcloud:main Jun 30, 2026
60 of 64 checks passed
@omnizs38
omnizs38 deleted the fix/replace-alert-with-showwarning-in-tablecell branch June 30, 2026 08:21
@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants