Conversation
OCA.Viewer.open() took the folder of a file info's source as the root of the node it builds. For a source on dav, that folder starts with /remote.php/dav, and a node rejects it: Error: The root must be relative to the service. e.g /files/emma Apps hand over the dav address of the file they open, as the photos app does for every photo, so none of them opened. A dav source now gets the home of its service as root, /files/emma or /photos/emma; any other source keeps its folder. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
Member
Author
|
/compile |
skjnldsv
force-pushed
the
fix/viewer-legacy-dav-root
branch
from
October 2, 2026 14:38
db3565f to
67f37f4
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the viewer moved into the server,
OCA.Viewer.open()fails for any file info whosesourceis on dav, which is what the photos app hands over for every photo:nodeFromFileInfotook the folder of the source as the root of the node it builds. For a dav source that folder starts with/remote.php/dav, and the node rejects it. A dav source now gets the home of its service as root (/files/emma,/photos/emma); any other source keeps its folder, as before.Found on nextcloud/photos#3919, where every Playwright test opening a photo fails with the error above: https://github.com/nextcloud/photos/actions/runs/36981741535
The two new cases in
legacy.spec.tsfail without the change and pass with it.👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.