feat(admin_audit): add stable operation identifier to audit log entries - #65007
Open
GhassenKefi wants to merge 1 commit into
Open
GhassenKefi wants to merge 1 commit into
GhassenKefi wants to merge 1 commit into
Conversation
Every audit log entry now carries a machine-readable "operation" field (e.g. "files.file.read") in its data, next to the human-readable message. Log consumers can filter on it instead of matching message text, which may change between releases. The names are defined once in the new OCA\AdminAudit\Operation enum. CriticalActionPerformedEvent gets an optional $operation parameter so other apps can provide their own. Refs nextcloud-gmbh/governance#199 Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Ghassen kefi <ghassen.kefi.dev@gmail.com>
GhassenKefi
requested review from
icewind1991,
leftybournes,
provokateurin and
salmart-dev
and removed request for
a team
October 2, 2026 10:01
susnux
reviewed
Oct 2, 2026
| * @param string $logMessage | ||
| * @param array $parameters | ||
| * @param bool $obfuscateParameters | ||
| * @param ?string $operation Stable identifier of the action in the form `app.entity.action`, e.g. `federatedfilesharing.share.accepted` |
Contributor
There was a problem hiding this comment.
if we want to enforce this format then we should check this in the constructor.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every audit log entry now carries a machine-readable "operation" field (e.g. "files.file.read") in its data, next to the human-readable message. Log consumers can filter on it instead of matching message text, which may change between releases.
The names are defined once in the new OCA\AdminAudit\Operation enum. CriticalActionPerformedEvent gets an optional $operation parameter so other apps can provide their own.
Refs nextcloud-gmbh/governance#199
Assisted-by: ClaudeCode:claude-opus-5-5
Summary
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)