fix(theming): Fix imagick segmentation fault when rendering an app icon - #64955
Merged
provokateurin merged 1 commit intoOct 2, 2026
Merged
Conversation
Member
Author
|
/backport to stable35 |
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
Member
|
Is |
Member
Author
|
I just checked and in all requests I observed it was 512. |
CarlSchwan
approved these changes
Oct 1, 2026
icewind1991
approved these changes
Oct 1, 2026
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
force-pushed
the
fix/theming/app-icon-imagick-segmentation-fault
branch
from
October 2, 2026 09:25
7d7098f to
34774af
Compare
Member
Author
|
The tests for this stuff are pretty bad, because they just have the same code to generate the icon and compare it 😭 |
provokateurin
enabled auto-merge
October 2, 2026 09:26
provokateurin
deleted the
fix/theming/app-icon-imagick-segmentation-fault
branch
October 2, 2026 10:42
|
The backport to # Switch to the target branch and update it
git checkout stable33
git pull origin stable33
# Create the new backport branch
git checkout -b backport/64955/stable33
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 34774afd
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/64955/stable33Error: Failed to check for changes with origin/stable33: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Member
Author
|
stable33 doesn't have the same issue, so no backport needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since a few months my imagick happily segfaults on the
drawImagein the next line, taking down the entire web server. I have no idea why this change fixes it, but it does 🤷♀️