Skip to content

fix(theming): Fix imagick segmentation fault when rendering an app icon - #64955

Merged
provokateurin merged 1 commit into
masterfrom
fix/theming/app-icon-imagick-segmentation-fault
Oct 2, 2026
Merged

provokateurin merged 1 commit into
masterfrom
fix/theming/app-icon-imagick-segmentation-fault

Conversation

@provokateurin

Copy link
Copy Markdown
Member

Since a few months my imagick happily segfaults on the drawImage in the next line, taking down the entire web server. I have no idea why this change fixes it, but it does 🤷‍♀️

@provokateurin provokateurin added this to the Nextcloud 36 milestone Sep 30, 2026
@provokateurin
provokateurin requested a review from a team as a code owner September 30, 2026 16:48
@provokateurin
provokateurin removed the request for review from a team September 30, 2026 16:48
@provokateurin provokateurin added the 3. to review Waiting for reviews label Sep 30, 2026
@provokateurin

Copy link
Copy Markdown
Member Author

/backport to stable35

@provokateurin

Copy link
Copy Markdown
Member Author

/backport to stable34

@provokateurin

Copy link
Copy Markdown
Member Author

/backport to stable33

@icewind1991

icewind1991 commented Sep 30, 2026 •

Copy link
Copy Markdown
Member

Is $size 0/1 sometimes by any chance?

@provokateurin

Copy link
Copy Markdown
Member Author

I just checked and in all requests I observed it was 512.

Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin
provokateurin force-pushed the fix/theming/app-icon-imagick-segmentation-fault branch from 7d7098f to 34774af Compare October 2, 2026 09:25
@provokateurin

Copy link
Copy Markdown
Member Author

The tests for this stuff are pretty bad, because they just have the same code to generate the icon and compare it 😭

@provokateurin
provokateurin merged commit 463c9bd into master Oct 2, 2026
166 of 168 checks passed
@provokateurin
provokateurin deleted the fix/theming/app-icon-imagick-segmentation-fault branch October 2, 2026 10:42
@backportbot

backportbot Bot commented Oct 2, 2026

Copy link
Copy Markdown

The backport to stable33 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable33
git pull origin stable33

# Create the new backport branch
git checkout -b backport/64955/stable33

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 34774afd

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/64955/stable33

Error: Failed to check for changes with origin/stable33: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@provokateurin

Copy link
Copy Markdown
Member Author

stable33 doesn't have the same issue, so no backport needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants