fix: Make Vue's ldapGroupMemberAssocAttr label map LcValue-compatible - #63672
fix: Make Vue's ldapGroupMemberAssocAttr label map LcValue-compatible#63672j-frei wants to merge 1 commit into
Conversation
joshtrichards
left a comment
There was a problem hiding this comment.
Makes sense. As an aside, LDAP configuration frontend could really use test coverage! A future follow-up PR idea for someone.
|
/backport to stable35 |
|
/backport to stable34 |
|
/backport to stable33 |
|
@j-frei DCO check needs to be remedied https://github.com/nextcloud/server/pull/63672/checks?check_run_id=98282405379 |
…atible Signed-off-by: Johann Frei <johann.frei@informatik.uni-augsburg.de>
d609feb to
5bf8d41
Compare
|
@joshtrichards Thanks! DCO should be fixed now. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
The user_ldap plugin features the field ldapGroupMemberAssocAttr and its values are converted into lowercase when set. In the UI, the field loads the labels using the groupMemberAssociation constant, which used to be case-sensitive.
It failed for all entries other than 'member' because these fields had upper letters in it; resulting in the settings panel to display the GUI field as empty.
This is fixed here. (Tested on v33.0.2)
It could be partially related to #60342, but just viewing the field before this PR did not change the ldap settings in my tests.