Repository navigation
fix: prevent editing end-to-end encrypted files - #4476
Merged
Merged
Conversation
Centralize encryption checks and guard editor actions, Quick Look modifications, cropping, and saving for encrypted files. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Share server deletion logic between main and viewer menus, checking permissions and connectivity and notifying delegates after encrypted deletions. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
mvanhorn
added a commit
to mvanhorn/nextcloud-ios
that referenced
this pull request
Nov 18, 2026
…ewer-edit-action Resolve conflicts with the end-to-end encryption edit guard (nextcloud#4476): keep the isModifiableWithQuickLook check before the Quick Look transfer selector opens the shared presentEditor path, keep the per-editor change flag together with the isEditingEnabled guard on saved copies, and keep the online-or-local condition for the viewer's Edit action. Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Centralize encryption checks and guard editor actions, Quick Look modifications, cropping, and saving for encrypted files.
🤖 AI (if applicable)