test(phpunit): fix DirectDownloadService phpunit test - #1182
Merged
Merged
Conversation
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
saw-jan
requested review from
Ashim-Stha,
Kharonus,
NobodysNightmare,
ba1ash,
dominic-braeunlein,
individual-it,
julien-nc,
psatyal,
shiroginne and
wielinde
as code owners
September 22, 2026 06:52
Collaborator
Author
|
/backport to release/3.3 |
Ashim-Stha
approved these changes
Sep 22, 2026
Contributor
|
The backport to # Switch to the target branch and update it
git checkout release/3.3
git pull origin release/3.3
# Create the new backport branch
git checkout -b backport/1182/release/3.3
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 77a6186b
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/1182/release/3.3Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Collaborator
Author
|
/backport c306b10 to release/3.3 |
saw-jan
added a commit
that referenced
this pull request
Sep 22, 2026
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
saw-jan
added a commit
that referenced
this pull request
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mock the external classes to get the desired return for unit testing. Test the external methods call and return of the test method.
Related Issue or Workpackage
Types of changes
Checklist:
CHANGELOG.mdfile