fix(warnings): ensure compilation without warnings with gcc 16

src/common/syncjournaldb.cpp

@@ -1,9 +1,19 @@
 /*
  * SPDX-FileCopyrightText: 2020 Nextcloud GmbH and Nextcloud contributors
  * SPDX-FileCopyrightText: 2014 ownCloud GmbH
  * SPDX-License-Identifier: LGPL-2.1-or-later
  */
 
+
+#include "syncjournaldb.h"
+
+#include "version.h"
+#include "filesystembase.h"
+#include "common/asserts.h"
+#include "common/checksums.h"
+#include "common/preparedsqlquerymanager.h"
+#include "common/c_jhash.h"
+
 #include <QCryptographicHash>
 #include <QFile>
 #include <QJsonArray>
@@ -13,17 +23,10 @@
 #include <QElapsedTimer>
 #include <QUrl>
 #include <QDir>
-#include <sqlite3.h>
-#include <cstring>
 
-#include "common/syncjournaldb.h"
-#include "version.h"
-#include "filesystembase.h"
-#include "common/asserts.h"
-#include "common/checksums.h"
-#include "common/preparedsqlquerymanager.h"
+#include <sqlite3.h>
 
-#include "common/c_jhash.h"
+#include <cstring>
 
 // SQL expression to check whether path.startswith(prefix + '/')
 // Note: '/' + 1 == '0'
@@ -3311,3 +3314,5 @@
 }
 
 } // namespace OCC
+
+#include "moc_syncjournaldb.cpp"

src/gui/socketapi/CMakeLists.txt

@@ -4,6 +4,7 @@
 target_sources(nextcloudCore PRIVATE
     ${CMAKE_CURRENT_SOURCE_DIR}/socketapi.h
     ${CMAKE_CURRENT_SOURCE_DIR}/socketapi.cpp
+    ${CMAKE_CURRENT_SOURCE_DIR}/socketapi_p.h
 )
 
 if( APPLE )

src/gui/socketapi/socketapi.cpp

@@ -1766,3 +1766,4 @@
 } // namespace OCC
 
 #include "socketapi.moc"
+#include "moc_socketapi_p.cpp"

src/gui/socketapi/socketapi_p.h

@@ -7,16 +7,16 @@
 #ifndef SOCKETAPI_P_H
 #define SOCKETAPI_P_H
 
-#include <functional>
 #include <QBitArray>
 #include <QIODevice>
 #include <QPointer>
-
 #include <QJsonDocument>
 #include <QJsonObject>
+#include <QTimer>
+#include <QLoggingCategory>
 
+#include <functional>
 #include <memory>
-#include <QTimer>
 
 namespace OCC {
 

src/libsync/basepropagateremotedeleteencrypted.cpp

@@ -3,7 +3,7 @@
  * SPDX-License-Identifier: GPL-2.0-or-later
  */
 
 #include <QFileInfo>
 #include <QLoggingCategory>
 #include "foldermetadata.h"
 #include "basepropagateremotedeleteencrypted.h"
@@ -197,3 +197,5 @@
 }
 
 } // namespace OCC
+
+#include "moc_basepropagateremotedeleteencrypted.cpp"

src/libsync/bulkpropagatordownloadjob.cpp

@@ -165,3 +165,5 @@
 }
 
 }
+
+#include "moc_bulkpropagatordownloadjob.cpp"

src/libsync/bulkpropagatorjob.cpp

@@ -819,3 +819,5 @@
 }
 
 }
+
+#include "moc_bulkpropagatorjob.cpp"

src/libsync/creds/abstractcredentials.cpp

@@ -4,12 +4,13 @@
  * SPDX-License-Identifier: GPL-2.0-or-later
  */
 
+#include "abstractcredentials.h"
+
 #include <QLoggingCategory>
 #include <QString>
 #include <QCoreApplication>
 
 #include "common/asserts.h"
-#include "creds/abstractcredentials.h"
 
 namespace OCC {
 
@@ -59,3 +60,5 @@
     return key;
 }
 } // namespace OCC
+
+#include "moc_abstractcredentials.cpp"

src/libsync/creds/dummycredentials.cpp

@@ -4,7 +4,7 @@
  * SPDX-License-Identifier: GPL-2.0-or-later
  */
 
 #include "creds/dummycredentials.h"
 #include "accessmanager.h"
 
 namespace OCC {
@@ -58,3 +58,5 @@
 }
 
 } // namespace OCC
+
+#include "moc_dummycredentials.cpp"

src/libsync/creds/httpcredentials.cpp

@@ -4,7 +4,7 @@
  * SPDX-License-Identifier: GPL-2.0-or-later
  */
 
 #include <QLoggingCategory>
 #include <QMutex>
 #include <QNetworkReply>
 #include <QSettings>
@@ -555,3 +555,5 @@
 }
 
 } // namespace OCC
+
+#include "moc_httpcredentials.cpp"

src/libsync/discovery.cpp

@@ -2549,3 +2549,5 @@
 }
 
 }
+
+#include "moc_discovery.cpp"

src/libsync/encryptedfoldermetadatahandler.cpp

@@ -394,3 +394,5 @@
 }
 
 }
+
+#include "moc_encryptedfoldermetadatahandler.cpp"

src/libsync/encryptfolderjob.cpp

@@ -148,3 +148,5 @@ void EncryptFolderJob::slotUploadMetadataFinished(int statusCode, const QString
 }
 
 }
+
+#include "moc_encryptfolderjob.cpp"

src/libsync/foldermetadata.cpp

@@ -1270,3 +1270,5 @@ bool FolderMetadata::verifyMetadataKey(const QByteArray &metadataKey) const
     return _keyChecksums.contains(calcSha256(metadataKeyLimitedLength)) || _keyChecksums.isEmpty();
 }
 }
+
+#include "moc_foldermetadata.cpp"

src/libsync/owncloudpropagator.cpp

@@ -1835,3 +1835,5 @@ void PropagateVfsUpdateMetadataJob::start()
 }
 
 }
+
+#include "moc_owncloudpropagator.cpp"

src/libsync/propagatedownload.cpp

@@ -4,7 +4,7 @@
  * SPDX-License-Identifier: GPL-2.0-or-later
  */
 
 #include "config.h"
 #include "libsync/creds/abstractcredentials.h"
 #include "owncloudpropagator_p.h"
 #include "propagatedownload.h"
@@ -1394,3 +1394,5 @@
     }
 }
 }
+
+#include "moc_propagatedownload.cpp"

src/libsync/propagatedownloadencrypted.cpp

@@ -119,3 +119,5 @@ QString PropagateDownloadEncrypted::errorString() const
 }
 
 }
+
+#include "moc_propagatedownloadencrypted.cpp"

src/libsync/propagateremotedelete.cpp

@@ -130,3 +130,5 @@ void PropagateRemoteDelete::slotDeleteJobFinished()
     done(SyncFileItem::Success, {}, ErrorCategory::NoError);
 }
 }
+
+#include "moc_propagateremotedelete.cpp"

src/libsync/propagateremotedeleteencrypted.cpp

@@ -74,3 +74,5 @@ void PropagateRemoteDeleteEncrypted::slotUpdateMetadataJobFinished(int statusCod
     Q_UNUSED(message);
     deleteRemoteItem(_item->_encryptedFileName);
 }
+
+#include "moc_propagateremotedeleteencrypted.cpp"

src/libsync/propagateremotedeleteencryptedrootfolder.cpp

@@ -14,7 +14,7 @@
  * - 7th step is to decrypt and delete the root folder, because it is now possible as it has become empty
  */
 
 #include <QFileInfo>
 #include <QLoggingCategory>
 
 #include "deletejob.h"
@@ -196,3 +196,5 @@
     });
     job->start();
 }
+
+#include "moc_propagateremotedeleteencryptedrootfolder.cpp"

src/libsync/propagateremotemkdir.cpp

@@ -285,3 +285,5 @@ void PropagateRemoteMkdir::success()
     done(SyncFileItem::Success, {}, ErrorCategory::NoError);
 }
 }
+
+#include "moc_propagateremotemkdir.cpp"

src/libsync/propagateremotemove.cpp

@@ -341,3 +341,5 @@ bool PropagateRemoteMove::adjustSelectiveSync(SyncJournalDb *journal, const QStr
     return true;
 }
 }
+
+#include "moc_propagateremotemove.cpp"

src/libsync/propagateupload.cpp

@@ -4,7 +4,7 @@
  * SPDX-License-Identifier: GPL-2.0-or-later
  */
 
 #include "config.h"
 #include "propagateupload.h"
 #include "propagateuploadencrypted.h"
 #include "owncloudpropagator_p.h"
@@ -925,3 +925,5 @@
         emit abortFinished();
 }
 }
+
+#include "moc_propagateupload.cpp"

src/libsync/propagateuploadencrypted.cpp

@@ -195,3 +195,5 @@ void PropagateUploadEncrypted::slotUploadMetadataFinished(int statusCode, const
 }
 
 } // namespace OCC
+
+#include "moc_propagateuploadencrypted.cpp"

src/libsync/propagatorjobs.cpp

@@ -590,3 +590,5 @@ bool PropagateLocalRename::deleteOldDbRecord(const QString &fileName)
     return true;
 }
 }
+
+#include "moc_propagatorjobs.cpp"

src/libsync/putmultifilejob.cpp

@@ -112,3 +112,5 @@ std::chrono::milliseconds PutMultiFileJob::msSinceStart() const
 }
 
 }
+
+#include "moc_putmultifilejob.cpp"

src/libsync/updatee2eefoldermetadatajob.cpp

@@ -167,3 +167,5 @@ void UpdateE2eeFolderMetadataJob::unlockFolder(const EncryptedFolderMetadataHand
 }
 
 }
+
+#include "moc_updatee2eefoldermetadatajob.cpp"

src/libsync/updatee2eefolderusersmetadatajob.cpp

@@ -365,3 +365,5 @@ const QByteArray UpdateE2eeFolderUsersMetadataJob::folderToken() const
 }
 
 }
+
+#include "moc_updatee2eefolderusersmetadatajob.cpp"

src/libsync/updatemigratede2eemetadatajob.cpp

@@ -87,3 +87,5 @@ void UpdateMigratedE2eeMetadataJob::addSubJobItem(const QString &key, const Sync
 }
 
 }
+
+#include "moc_updatemigratede2eemetadatajob.cpp"