fix(file-provider): Clean up stale chunked upload chunks by claucambra · Pull Request #10565 · nextcloud/desktop

claucambra · 2026-08-10T07:30:36Z

Summary

Chunked upload chunks can stick around after upload attempts, filling up local storage. This PR adds various cleanup procedures to prevent this from happening

Checklist

Sign-off message is added to all commits.
The commit history is clean with no merge commits.
- How to rebase your commits
- How to squash commits with rebase
Uploaded screenshots from before and after for UI changes.
Test(s) added to branch, with before/after results included in PR description, for performance improvements where applicable.
Documentation has been updated or is not required.
Backports requested where applicable (critical bugfixes).
Labels added where applicable (bug/enhancement).
Milestone added for target version.

AI (if applicable)

The content of this PR was partly or fully generated using AI
- I have read the guidelines for AI-assisted contributions.
- I have read Nextcloud's AI Contribution Policy.

Copilot

Pull request overview

Adds lifecycle management for local chunked-upload files and bookkeeping.

Changes:

Cleans chunks after uploads, deletions, and extension startup.
Extends remote interfaces to expose and remove chunk directories.
Adds regression tests and lifecycle documentation.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
`UploadTests.swift`	Tests upload cleanup and resume behavior.
`ItemModifyTests.swift`	Tests metadata retention after failures.
`ItemDeleteTests.swift`	Tests cleanup during deletion.
`ChunkUploadCleanupTests.swift`	Tests startup cleanup policies.
`MockRemoteInterfaceTests.swift`	Tests mock chunk storage.
`MockRemoteInterface.swift`	Simulates chunk files and removal.
`TestableRemoteInterface.swift`	Updates protocol test implementation.
`Upload.swift`	Integrates upload cleanup lifecycle.
`ChunkUploadCleanup.swift`	Adds cleanup and bookkeeping helpers.
`Item+Modify.swift`	Preserves or clears upload identifiers.
`Item+Delete.swift`	Cleans uploads after deletion.
`RemoteInterface.swift`	Extends the chunk-upload contract.
`NextcloudKit+RemoteInterface.swift`	Implements local chunk removal.
`FileProviderExtension.swift`	Runs cleanup during startup.
`Documentation.md`	Links the new design note.
`ChunkedUploads.md`	Documents chunk lifecycle behavior.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

+            // TODO: Initial file creation does not persist item metadata until the upload succeeds.
+            // Running cleanup during setup therefore removes its remaining chunks after an extension
+            // restart, before File Provider can resume the create. Persist pending-create metadata,
+            // or otherwise distinguish pending local creations from abandoned uploads, first.
+            cleanupAbandonedChunkUploads(


+        let legacyPrefix = chunkUploadIdentifierPrefix(forItemWithIdentifier: itemIdentifier)
+        let chunkIdentifiers = db.objects(RemoteFileChunk.self)
+            .where { $0.remoteChunkStoreFolderName.starts(with: legacyPrefix) }
+            .map(\.remoteChunkStoreFolderName)


        newMetadata.sessionTaskIdentifier = 0
        newMetadata.downloaded = true
        newMetadata.uploaded = true
+        newMetadata.chunkUploadId = nil


+                discardChunkUploads(
+                    forItemIdentifiers: chunkUploadOwnerIdentifiers,
+                    usingRemoteInterface: remoteInterface,
+                    dbManager: dbManager,
+                    logger: logger
+                )


+        logger.error(
+            "Could not remove local upload chunks.",
+            [.error: error, .name: uploadIdentifier]
+        )
+        return


…location Signed-off-by: Claudio Cambra <developer@claudiocambra.com>

…upload Signed-off-by: Claudio Cambra <developer@claudiocambra.com>

…ock remote interface Signed-off-by: Claudio Cambra <developer@claudiocambra.com>