fix(tray): scroll to top in the activity window on opening - #10533
fix(tray): scroll to top in the activity window on opening#10533Rello wants to merge 12 commits into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 88ef7e23a1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5d543522c2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
7458c8c to
2f96fe9
Compare
|
@claucambra please recheck |
d326775 to
5b8b9c8
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e204ea90ad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| onActiveChanged: { | ||
| if (active) { | ||
| resetActivityList() |
There was a problem hiding this comment.
When the cached activities window remains visible and requestActivate() either leaves an already-active window unchanged or is rejected by the window manager, neither visibleChanged nor this activeChanged handler fires, so Systray::showActivitiesWindow() still returns without resetting the stale viewport. Fresh evidence in this revision is that the reset now depends solely on successful activation, while the activation test explicitly skips environments where window activation cannot be exercised; invoke the reset directly for each cached-window open request instead.
AGENTS.md reference: AGENTS.md:L207-L209
Useful? React with 👍 / 👎.
|
Artifact containing the AppImage: nextcloud-appimage-pr-10533.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
- reopening will ensure tha the list is scrolled to the top - before, the scroll location was memorized and and new notifications or conflicts were missed Assisted-by: Codex:GPT-5 Signed-off-by: Rello <github@scherello.de>
Assisted-by: Codex:GPT-5 Signed-off-by: Rello <github@scherello.de>
Assisted-by: Codex:GPT-5 Signed-off-by: Rello <github@scherello.de>
Assisted-by: Codex:GPT-5 Signed-off-by: Rello <github@scherello.de>
…resources and registers the production SVG image provider Assisted-by: Codex:GPT-5 Signed-off-by: Rello <github@scherello.de>
Assisted-by: Codex:GPT-5 Signed-off-by: Rello <github@scherello.de>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
- confirms Qt created a highlight before reset; - treats a destroyed highlightItem as the valid hidden state after reset; - no longer dereferences the stale highlight object. Assisted-by: Codex:GPT-5 Signed-off-by: Rello <github@scherello.de>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
e204ea9 to
0ddfbe8
Compare
|
4 participants
Assisted-by: Codex:GPT-5