draft: support for unified sharing

REUSE.toml

@@ -125,6 +125,12 @@ precedence = "aggregate"
 SPDX-FileCopyrightText = "2018-2025 Google LLC"
 SPDX-License-Identifier = "Apache-2.0"
 
+[[annotations]]
+path = ["theme/back.svg"]
+precedence = "aggregate"
+SPDX-FileCopyrightText = "2018-2025 Google LLC"
+SPDX-License-Identifier = "Apache-2.0"
+
 [[annotations]]
 path = ["theme/security.svg", "theme/file-clock-outline.svg"]
 precedence = "aggregate"

resources.qrc

@@ -40,6 +40,8 @@
         <file>src/gui/tray/TrayWindowHeader.qml</file>
         <file>src/gui/activity/qml/ActivityItemContextMenu.qml</file>
         <file>src/gui/activity/qml/ActivityItemActions.qml</file>
+        <file>src/gui/activity/qml/ActivityFileMenu.qml</file>
+        <file>src/gui/activity/qml/ActivityFileMenuButton.qml</file>
         <file>src/gui/activity/qml/ActivityItemContent.qml</file>
         <file>src/gui/activity/qml/TalkReplyTextField.qml</file>
         <file>src/gui/tray/CallNotificationDialog.qml</file>
@@ -70,6 +72,7 @@
         <file>src/gui/wizard/qml/WizardButton.qml</file>
         <file>src/gui/wizard/qml/WizardComboBox.qml</file>
         <file>src/gui/wizard/qml/WizardDialogFrame.qml</file>
+        <file>src/gui/wizard/qml/WizardItemDelegate.qml</file>
         <file>src/gui/wizard/qml/WizardTextField.qml</file>
         <file>src/gui/macOS/ui/FileProviderFileDelegate.qml</file>
         <file>src/gui/integration/FileActionsWindow.qml</file>

shell_integration/MacOSX/NextcloudFileProviderKit/Sources/NextcloudFileProviderKit/Services/FPUIExtensionService.swift

@@ -36,4 +36,11 @@ public let fpUiExtensionServiceName = NSFileProviderServiceName("com.nextcloud.d
     /// Get a server URL for the given local file provider item.
     ///
     func itemServerPath(identifier: NSFileProviderItemIdentifier) async -> NSString?
+
+    ///
+    /// Present the unified sharing dialog for the given local file provider item when supported.
+    ///
+    /// - Returns: `true` when the request was handed to the main app, otherwise `false` so the caller can use the legacy sharing interface.
+    ///
+    func presentUnifiedSharingDialog(identifier: NSFileProviderItemIdentifier, localPath: NSString) async -> Bool
 }

shell_integration/MacOSX/NextcloudFileProviderKit/Sources/NextcloudFileProviderKit/Services/FPUIExtensionServiceSource.swift

@@ -92,4 +92,45 @@ class FPUIExtensionServiceSource: NSObject, NSFileProviderServiceSource, NSXPCLi
         let completePath = item.serverUrl + "/" + item.fileName
         return completePath.replacingOccurrences(of: baseUrl, with: "") as NSString
     }
+
+    func presentUnifiedSharingDialog(identifier: NSFileProviderItemIdentifier, localPath: NSString) async -> Bool {
+        guard let account = fpExtension.ncAccount else {
+            logger.error("Could not present unified sharing because the account is unavailable.", [.item: identifier])
+            return false
+        }
+
+        guard let dbManager = fpExtension.dbManager,
+              let metadata = dbManager.itemMetadata(identifier),
+              !metadata.fileId.isEmpty
+        else {
+            logger.error("Could not present unified sharing because the item metadata or numeric file id is unavailable.", [.item: identifier])
+            return false
+        }
+
+        let (_, _, responseData, error) = await fpExtension.ncKit.fetchCapabilities(account: account)
+        guard error == .success else {
+            logger.error("Could not determine whether unified sharing is supported.", [.item: identifier, .error: error])
+            return false
+        }
+
+        guard UnifiedSharingCapability.isAvailable(in: responseData) else {
+            logger.info("Unified sharing is not supported; using the legacy sharing interface.", [.item: identifier])
+            return false
+        }
+
+        guard let app = fpExtension.app else {
+            logger.error("Could not present unified sharing because the main app connection is unavailable.", [.item: identifier])
+            return false
+        }
+
+        let domainIdentifier = fpExtension.domain.identifier.rawValue
+        app.presentUnifiedSharing(
+            forItem: metadata.fileId,
+            localPath: localPath as String,
+            remoteItemPath: metadata.path,
+            forDomainIdentifier: domainIdentifier
+        )
+        logger.info("Asked the main app to present unified sharing.", [.item: identifier, .domain: fpExtension.domain.identifier])
+        return true
+    }
 }

shell_integration/MacOSX/NextcloudFileProviderKit/Sources/NextcloudFileProviderKit/Utilities/UnifiedSharingCapability.swift

@@ -0,0 +1,19 @@
+//  SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
+//  SPDX-License-Identifier: LGPL-3.0-or-later
+
+import Foundation
+
+enum UnifiedSharingCapability {
+    static func isAvailable(in responseData: Data?) -> Bool {
+        guard let responseData,
+              let root = try? JSONSerialization.jsonObject(with: responseData) as? [String: Any],
+              let ocs = root["ocs"] as? [String: Any],
+              let data = ocs["data"] as? [String: Any],
+              let capabilities = data["capabilities"] as? [String: Any]
+        else {
+            return false
+        }
+
+        return capabilities.keys.contains("sharing")
+    }
+}

shell_integration/MacOSX/NextcloudFileProviderKit/Sources/NextcloudFileProviderXPC/include/AppProtocol.h

@@ -23,6 +23,19 @@ NS_ASSUME_NONNULL_BEGIN
  */
 - (void)presentFileActions:(NSString *)fileId path:(NSString *)path remoteItemPath:(NSString *)remoteItemPath withDomainIdentifier:(NSString *)domainIdentifier;
 
+/**
+ * @brief The file provider extension asks the main app to present the unified sharing dialog for an item.
+ * @param fileId The numeric server file id, equal to the WebDAV `fileid` property.
+ * @param localPath The local and absolute path of the item.
+ * @param remoteItemPath The server-side path of the item.
+ * @param domainIdentifier The file provider domain identifier for the account that owns the item.
+ */
+- (void)presentUnifiedSharingForItem:(NSString *)fileId
+                          localPath:(NSString *)localPath
+                     remoteItemPath:(NSString *)remoteItemPath
+                forDomainIdentifier:(NSString *)domainIdentifier
+    NS_SWIFT_NAME(presentUnifiedSharing(forItem:localPath:remoteItemPath:forDomainIdentifier:));
+
 /**
  * @brief The file provider extension asks the main app to open the item's page in the user's web browser.
  *

shell_integration/MacOSX/NextcloudFileProviderKit/Tests/NextcloudFileProviderKitTests/BundleExclusionReporterTests.swift

@@ -30,6 +30,13 @@ private final class CapturingAppProxy: NSObject, AppProtocol {
         presentedFileActions.append(fileId)
     }
 
+    func presentUnifiedSharing(
+        forItem _: String,
+        localPath _: String,
+        remoteItemPath _: String,
+        forDomainIdentifier _: String
+    ) {}
+
     /// Unused by these tests but required for protocol conformance — see
     /// `FileProviderExtensionOpenInBrowserTests` for the dedicated coverage.
     func openItemInBrowser(_: String, remoteItemPath _: String, forDomainIdentifier _: String) {}

shell_integration/MacOSX/NextcloudFileProviderKit/Tests/NextcloudFileProviderKitTests/InsufficientQuotaReporterTests.swift

@@ -26,6 +26,13 @@ private final class CapturingAppProxy: NSObject, AppProtocol {
         _: String, path _: String, remoteItemPath _: String, withDomainIdentifier _: String
     ) {}
 
+    func presentUnifiedSharing(
+        forItem _: String,
+        localPath _: String,
+        remoteItemPath _: String,
+        forDomainIdentifier _: String
+    ) {}
+
     func openItemInBrowser(_: String, remoteItemPath _: String, forDomainIdentifier _: String) {}
 
     func copyInternalLink(forItem _: String, remoteItemPath _: String, forDomainIdentifier _: String) {}

shell_integration/MacOSX/NextcloudFileProviderKit/Tests/NextcloudFileProviderKitTests/ItemCreateTests.swift

@@ -25,6 +25,7 @@ final class QuotaCapturingAppProxy: NSObject, AppProtocol {
     var capturedSummaryDomains: [String] = []
 
     func presentFileActions(_: String, path _: String, remoteItemPath _: String, withDomainIdentifier _: String) {}
+    func presentUnifiedSharing(forItem _: String, localPath _: String, remoteItemPath _: String, forDomainIdentifier _: String) {}
     func openItemInBrowser(_: String, remoteItemPath _: String, forDomainIdentifier _: String) {}
     func copyInternalLink(forItem _: String, remoteItemPath _: String, forDomainIdentifier _: String) {}
     func reportSyncStatus(_: String, forDomainIdentifier _: String) {}

shell_integration/MacOSX/NextcloudFileProviderKit/Tests/NextcloudFileProviderKitTests/ReportCurrentSyncStateTests.swift

@@ -17,6 +17,7 @@ private final class SyncStatusCapturingAppProxy: NSObject, AppProtocol {
 
     // The following are unused by these tests but required for protocol conformance.
     func presentFileActions(_: String, path _: String, remoteItemPath _: String, withDomainIdentifier _: String) {}
+    func presentUnifiedSharing(forItem _: String, localPath _: String, remoteItemPath _: String, forDomainIdentifier _: String) {}
     func openItemInBrowser(_: String, remoteItemPath _: String, forDomainIdentifier _: String) {}
     func copyInternalLink(forItem _: String, remoteItemPath _: String, forDomainIdentifier _: String) {}
     func reportItemExcluded(fromSync _: String, fileName _: String, reason _: String, forDomainIdentifier _: String) {}

shell_integration/MacOSX/NextcloudFileProviderKit/Tests/NextcloudFileProviderKitTests/UnifiedSharingCapabilityTests.swift

@@ -0,0 +1,36 @@
+//  SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
+//  SPDX-License-Identifier: LGPL-3.0-or-later
+
+import Foundation
+@testable import NextcloudFileProviderKit
+import Testing
+
+@Suite("Unified sharing capability")
+struct UnifiedSharingCapabilityTests {
+    @Test("Detects the sharing capability")
+    func detectsSharingCapability() {
+        let responseData = Data(#"{"ocs":{"data":{"capabilities":{"sharing":{}}}}}"#.utf8)
+
+        #expect(UnifiedSharingCapability.isAvailable(in: responseData))
+    }
+
+    @Test("Treats the presence of a null sharing capability as available")
+    func detectsNullSharingCapability() {
+        let responseData = Data(#"{"ocs":{"data":{"capabilities":{"sharing":null}}}}"#.utf8)
+
+        #expect(UnifiedSharingCapability.isAvailable(in: responseData))
+    }
+
+    @Test("Rejects a capabilities response without sharing")
+    func rejectsMissingSharingCapability() {
+        let responseData = Data(#"{"ocs":{"data":{"capabilities":{"files":{}}}}}"#.utf8)
+
+        #expect(!UnifiedSharingCapability.isAvailable(in: responseData))
+    }
+
+    @Test("Rejects malformed capability data")
+    func rejectsMalformedCapabilityData() {
+        #expect(!UnifiedSharingCapability.isAvailable(in: Data("not json".utf8)))
+        #expect(!UnifiedSharingCapability.isAvailable(in: nil))
+    }
+}

shell_integration/MacOSX/NextcloudIntegration/FileProviderUIExt/DocumentActionViewController.swift

@@ -65,7 +65,7 @@ class DocumentActionViewController: FPUIActionExtensionViewController {
 
         switch (actionIdentifier) {
             case "com.nextcloud.desktopclient.FileProviderUIExt.ShareAction":
-                prepare(childViewController: ShareViewController(itemIdentifiers, serviceResolver: serviceResolver, log: log))
+                prepareSharingAction(itemIdentifiers: itemIdentifiers)
             case "com.nextcloud.desktopclient.FileProviderUIExt.LockFileAction":
                 prepare(childViewController: LockViewController(itemIdentifiers, locking: true, serviceResolver: serviceResolver, log: log))
             case "com.nextcloud.desktopclient.FileProviderUIExt.UnlockFileAction":
@@ -94,6 +94,42 @@ class DocumentActionViewController: FPUIActionExtensionViewController {
         self.view = NSView()
     }
 
+    // MARK: - Sharing
+
+    private func prepareSharingAction(itemIdentifiers: [NSFileProviderItemIdentifier]) {
+        guard itemIdentifiers.count == 1,
+              let itemIdentifier = itemIdentifiers.first,
+              let manager = NSFileProviderManager(for: domain)
+        else {
+            prepareLegacySharingAction(itemIdentifiers: itemIdentifiers)
+            return
+        }
+
+        Task { @MainActor in
+            do {
+                let localUrl = try await manager.getUserVisibleURL(for: itemIdentifier)
+                let service = try await serviceResolver.getService(at: localUrl)
+                let presented = await service.presentUnifiedSharingDialog(
+                    identifier: itemIdentifier,
+                    localPath: localUrl.path as NSString
+                )
+
+                if presented {
+                    extensionContext.completeRequest()
+                    return
+                }
+            } catch {
+                logger.error("Could not route the sharing action to unified sharing.", [.item: itemIdentifier, .error: error])
+            }
+
+            prepareLegacySharingAction(itemIdentifiers: itemIdentifiers)
+        }
+    }
+
+    private func prepareLegacySharingAction(itemIdentifiers: [NSFileProviderItemIdentifier]) {
+        prepare(childViewController: ShareViewController(itemIdentifiers, serviceResolver: serviceResolver, log: log))
+    }
+
     // MARK: - Eviction
 
     ///

src/gui/CMakeLists.txt

@@ -289,6 +289,7 @@ IF(BUILD_UPDATER)
 endif()
 
 add_subdirectory(search)
+add_subdirectory(sharing)
 
 IF( APPLE )
     list(APPEND client_SRCS cocoainitializer_mac.mm)
@@ -577,9 +578,6 @@ target_link_libraries(nextcloudCore
   Qt::QuickWidgets
   KF6::Archive
   KDAB::kdsingleapplication
-
-  nextcloudGuiSearch
-  nextcloudGuiSearchplugin
   )
 
 if(KF6GuiAddons_FOUND)
@@ -691,7 +689,13 @@ set_target_properties(nextcloud PROPERTIES
         RUNTIME_OUTPUT_DIRECTORY ${BIN_OUTPUT_DIRECTORY}
 )
 
-target_link_libraries(nextcloud PRIVATE nextcloudCore)
+target_link_libraries(nextcloud PRIVATE
+    nextcloudGuiSearch
+    nextcloudGuiSearchplugin
+    nextcloudGuiSharing
+    nextcloudGuiSharingplugin
+    nextcloudCore
+)
 
 if(TARGET PkgConfig::CLOUDPROVIDERS)
     message("Building with libcloudproviderssupport")

src/gui/activity/qml/ActivityFileMenu.qml

@@ -0,0 +1,46 @@
+/*
+ * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: GPL-2.0-or-later
+ */
+
+import QtQuick
+import QtQuick.Controls
+import "../../tray"
+
+Menu {
+    id: root
+
+    required property string filePath
+    required property bool serverHasIntegration
+    required property int itemFontPixelSize
+
+    signal fileDetailsRequested(string filePath)
+    signal fileActionsRequested(string filePath)
+
+    closePolicy: Menu.CloseOnPressOutsideParent | Menu.CloseOnEscape
+
+    property Action fileDetailsAction: Action {
+        id: fileDetailsAction
+        objectName: "fileDetailsAction"
+        text: qsTr("File details")
+        onTriggered: root.fileDetailsRequested(root.filePath)
+    }
+
+    property Action fileActionsAction: Action {
+        id: fileActionsAction
+        objectName: "fileActionsAction"
+        text: qsTr("File actions")
+        onTriggered: root.fileActionsRequested(root.filePath)
+    }
+
+    MenuItem {
+        id: fileDetailsMenuItem
+        action: root.fileDetailsAction
+    }
+
+    MenuItem {
+        id: fileActionsMenuItem
+        action: root.fileActionsAction
+        visible: root.serverHasIntegration
+    }
+}

src/gui/activity/qml/ActivityFileMenuButton.qml

@@ -0,0 +1,51 @@
+/*
+ * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: GPL-2.0-or-later
+ */
+
+import QtQuick
+import QtQuick.Controls
+
+Button {
+    id: root
+
+    required property string filePath
+    required property bool serverHasIntegration
+    required property int itemFontPixelSize
+    required property int buttonWidth
+    required property int buttonHeight
+    required property int buttonIconSize
+
+    readonly property alias menu: fileMenu
+
+    signal fileDetailsRequested(string filePath)
+    signal fileActionsRequested(string filePath)
+
+    width: buttonWidth
+    height: buttonHeight
+
+    icon.name: "view-more-symbolic"
+    icon.source: "image://svgimage-custom-color/more.svg/" + palette.buttonText
+    icon.width: buttonIconSize
+    icon.height: buttonIconSize
+
+    ToolTip {
+        popupType: Qt.platform.os === "windows" ? Popup.Item : Popup.Native
+        text: qsTr("Open file details")
+        visible: parent.hovered
+    }
+
+    display: Button.IconOnly
+    onClicked: fileMenu.visible ? fileMenu.close() : fileMenu.popup()
+
+    ActivityFileMenu {
+        id: fileMenu
+
+        filePath: root.filePath
+        serverHasIntegration: root.serverHasIntegration
+        itemFontPixelSize: root.itemFontPixelSize
+
+        onFileDetailsRequested: path => root.fileDetailsRequested(path)
+        onFileActionsRequested: path => root.fileActionsRequested(path)
+    }
+}