Skip to content

Fix overdue query to use dateTimeParameter (#7868) - #8676

Merged
blizzz merged 2 commits into
nextcloud:mainfrom
xstable:patch-2
Nov 16, 2026
Merged

blizzz merged 2 commits into
nextcloud:mainfrom
xstable:patch-2

Conversation

@xstable

@xstable xstable commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Summary

force to check date against UTC, instead of internal DB-Setting

closes nextcloud#7868
force to check date against UTC, instead of internal DB-Setting

Signed-off-by: XStable <info@xstable.com>

@blizzz blizzz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your attempt!

Comment thread lib/Db/CardMapper.php
$qb->select('id', 'title', 'duedate', 'notified')
->from('deck_cards')
->where($qb->expr()->lt('duedate', $qb->createFunction('NOW()')))
->where($qb->expr()->lt('duedate', $this->dateTimeParameter($qb, $now)))

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$now is not defined here

Signed-off-by: XStable <info@xstable.com>
@xstable

xstable commented Nov 13, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the review! $now is now defined in findOverdue() (new DateTime(), same pattern as the other queries in this mapper).

@xstable
xstable requested a review from blizzz November 13, 2026 14:59
@blizzz
blizzz merged commit 5e436a7 into nextcloud:main Nov 16, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Due-date notifications for Deck cards are triggered at the wrong time

2 participants