Skip to content

fix: catch DoesNotExistException in DeckShareProvider - #8458

Merged
blizzz merged 1 commit into
stable34from
fix/8433-deleting-a-board-breaks-filesystem
Oct 16, 2026
Merged

blizzz merged 1 commit into
stable34from
fix/8433-deleting-a-board-breaks-filesystem

Conversation

@grnd-alt

@grnd-alt grnd-alt commented Sep 28, 2026 •

Copy link
Copy Markdown
Member

Summary

Deleting a Board caused DeckShareProvider to rethrow a NotFoundException from the db query that was not caught.
That caused the file system to not be available until the cronjob actually deleted the board from the database.

We now catch that exception and remove the shares from the list.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

🤖 AI (if applicable)

  • [] The content of this PR was partly or fully generated using AI (N/A)

Signed-off-by: grnd-alt <git@belakkaf.net>
@grnd-alt
grnd-alt requested a review from a team September 28, 2026 09:18
@github-actions

Copy link
Copy Markdown
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 98827 was 93102 (+6.14%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@blizzz
blizzz merged commit 9620685 into stable34 Oct 16, 2026
44 checks passed
@blizzz
blizzz deleted the fix/8433-deleting-a-board-breaks-filesystem branch October 16, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants