Skip to content

fix: introduce includeDeleted param to cardMapper - #7844

Open
grnd-alt wants to merge 1 commit into
mainfrom
fix/includeDeleted
Open

grnd-alt wants to merge 1 commit into
mainfrom
fix/includeDeleted

Conversation

@grnd-alt

@grnd-alt grnd-alt commented Apr 13, 2026 •

Copy link
Copy Markdown
Member
  • Resolves: #
  • Target version: main

Summary

TODO

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@github-actions

Copy link
Copy Markdown
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 95993 was 93102 (+3.1%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@grnd-alt
grnd-alt force-pushed the fix/includeDeleted branch from 9579bb6 to 45b6667 Compare April 13, 2026 11:20
Signed-off-by: grnd-alt <git@belakkaf.net>
@grnd-alt
grnd-alt force-pushed the fix/includeDeleted branch from 45b6667 to c27992a Compare April 13, 2026 11:22
@github-actions

Copy link
Copy Markdown
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 95988 was 93102 (+3.09%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@github-actions

Copy link
Copy Markdown
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 95995 was 93102 (+3.1%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

foreach ($stacks as $stack) {
$data[$board->getId()]['stacks'][$stack->getId()] = $stack->jsonSerialize();
$cards = $this->cardMapper->findAllByStack($stack->getId());
$cards = $this->cardMapper->findAllByStack($stackId = $stack->getId(), null, null, $includeDeleted = true);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is something out of place, and probably something missing.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants