Skip to content

fix: use correct controller attributes for federation endpoints - #7816

Merged
grnd-alt merged 1 commit into
mainfrom
fix/federation-correct-controller-attributes
Apr 13, 2026
Merged

grnd-alt merged 1 commit into
mainfrom
fix/federation-correct-controller-attributes

Conversation

@grnd-alt

@grnd-alt grnd-alt commented Apr 2, 2026

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: grnd-alt <git@belakkaf.net>
@grnd-alt
grnd-alt requested review from blizzz, miaulalala and samin-z and removed request for elzody and luka-nextcloud April 2, 2026 14:11
@github-actions

github-actions Bot commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 96009 was 93102 (+3.12%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

#[NoAdminRequired]
#[PublicPage]
#[NoCSRFRequired]
#[RequestHeader(name: 'x-nextcloud-federation', description: 'Set to 1 when the request is performed by another Nextcloud Server to indicate a federation request', indirect: true)]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removal of federation header is intentional?

@grnd-alt
grnd-alt merged commit cfd69d2 into main Apr 13, 2026
45 of 47 checks passed
@grnd-alt
grnd-alt deleted the fix/federation-correct-controller-attributes branch April 13, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants