Repository navigation
introduce first pinia store - #7790
Merged
Merged
Conversation
grnd-alt
force-pushed
the
feat/pinia-migration
branch
from
March 24, 2026 16:06
198adf2 to
0b11f3b
Compare
grnd-alt
marked this pull request as draft
March 24, 2026 16:13
grnd-alt
force-pushed
the
feat/pinia-migration
branch
3 times, most recently
from
March 24, 2026 16:46
3418bc9 to
a639fd3
Compare
grnd-alt
marked this pull request as ready for review
March 25, 2026 08:23
mejo-
reviewed
Mar 26, 2026
grnd-alt
force-pushed
the
feat/pinia-migration
branch
2 times, most recently
from
March 30, 2026 09:31
19b171d to
eb53f25
Compare
Signed-off-by: grnd-alt <git@belakkaf.net>
grnd-alt
force-pushed
the
feat/pinia-migration
branch
from
March 30, 2026 09:44
eb53f25 to
dd050db
Compare
mejo-
approved these changes
Mar 31, 2026
mejo-
left a comment
Member
There was a problem hiding this comment.
Code changes look good now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To eventually migrate to vue3 we should first introduce pinia.
luckily, we can use pinia and vuex at the same time so we can do rather easy partial migrations.
This pr shows how to do that by copying the boardStore we had in main.js before to it's own store.
The vuex stores depend on each other so some of them have to be migrated at the same time to not break things. The actionsStore however does not have any dependencies and no other store depends on it so it can be easily migrated in one step.
migration plan for other pinia stores
attachment.jsrootState.currentBoardcardSetAttachmentCount,cardIncreaseAttachmentCount,cardDecreaseAttachmentCountcard.jsrootState.filter,rootState.stack.stacks,getters.stackById,getters.getSearchQueryaddStack,addBoardstack.jsthis.state.showArchived,this.state.currentBoard,rootState.card.cardssetCards,moveStackToTrash,updateCardPropertytrashbin.jsaddStack,addCardoverview.jssetCurrentBoard,addCardmain.jscurrentBoard,filter,showArchived, board mutationsdashboard.jscomment.jsactions.jsdashboard, comment and actions (this pr) can be migrated it self
the others most likely have to be migrated together (we could write to vuex store from pinia as a workaround, but I don't think we should)