You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
All contacts show *Last modified seconds ago* #3414
REV;VALUE=DATE-AND-OR-TIME:20230531T135555Z seems to be a valid format for v4.0 of vCards but invalid for v3.0 as far as I understand it and as written in this issue #1352 . I don't understand why version === '3.0' && type === 'vcardtime' return true (valid but actually invalid) here, and 4.0 return false (invalid but it is actually valid)
Ical.js says revValue.icalclass === 'vcardtime' for REV;VALUE=DATE-AND-OR-TIME:20230531T135555Z
and revValue.icalclass === 'icaltime' for REV:20230531T135555Z. Can't relate why.
So the actual problem is that the contacts app now writes vCard v4.0 and the fix wants to repair the valid REV.
To fix the issue, I would just add the case version === '4.0' && type === 'vcardtime' where the validation returns valid. But as stated I don't really get the implementation here.
Activity
meichthys commentedon May 26, 2023
I'm not seeing this in v 5.3.0-rc.2
Could it be a caching issue?
meichthys commentedon May 26, 2023
Maybe it's limited to recently contacted contacts?
ChristophWurst commentedon May 26, 2023
I still see it with 27 RC2. It happens with my own contacts, recently contacted and system contacts
meichthys commentedon May 26, 2023
Ok, for reference I'm on 26.0.1 RC1
I only have 1 recent contact but that does seem to have the issue, Other contacts are fine.
ChristophWurst commentedon May 31, 2023
I tested again and this only happens with system contacts. A contact in a real address book shows Last edited 5 months ago
ChristophWurst commentedon May 31, 2023
My impression is that we don't have a last modification date for every contact.
If we don't have the data we should hide the text
ChristophWurst commentedon May 31, 2023
nextcloud/server#38544 for a related feature request. The SAB contacts do not have a REV at the moment.
JohannesGGE commentedon May 31, 2023
I found where the magic happens:
contacts/src/services/checks/invalidREV.js
Lines 55 to 69 in 6f79fbc
The fix is called because the fallowing returns true in some cases:
contacts/src/services/checks/invalidREV.js
Lines 31 to 53 in 6f79fbc
One of these cases are the vCard created by the contacts app:
REV;VALUE=DATE-AND-OR-TIME:20230531T135555Zseems to be a valid format for v4.0 of vCards but invalid for v3.0 as far as I understand it and as written in this issue #1352 . I don't understand whyversion === '3.0' && type === 'vcardtime'return true (valid but actually invalid) here, and 4.0 return false (invalid but it is actually valid)Ical.js says
revValue.icalclass === 'vcardtime'forREV;VALUE=DATE-AND-OR-TIME:20230531T135555Zand
revValue.icalclass === 'icaltime'forREV:20230531T135555Z. Can't relate why.So the actual problem is that the contacts app now writes vCard v4.0 and the fix wants to repair the valid REV.
To fix the issue, I would just add the case
version === '4.0' && type === 'vcardtime'where the validation returns valid. But as stated I don't really get the implementation here.ChristophWurst commentedon May 31, 2023
Does it also try to repair read-only system accounts?
I have to dig into details of vcard v3 and v4 too. @st3iny might know a few things too.
JohannesGGE commentedon Jun 1, 2023
No, because SAB doesn't have REV yet, it will be set to now here:
contacts/src/models/contact.js
Lines 84 to 89 in bf01de8
st3iny commentedon Jun 1, 2023
Is hiding the rev if it's missing a valid workaround for now?
ChristophWurst commentedon Jun 1, 2023
contacts/src/components/ContactDetails.vue
Line 271 in 830f179
realDayaa commentedon May 29, 2025
I can confirm that contacts with REV;VALUE=DATE-TIME show up correctly.
and contacts with REV;VALUE=DATE-AND-OR-TIME don't.
st3iny commentedon Sep 25, 2025
Hi all, this should have been fixed by #4634 in the meantime. Please update the Contacts app and try again.