Repository navigation
fix: page list polling interval and failed page content fetches - #2947
Merged
Merged
Conversation
mejo-
force-pushed
the
fix/offline_page_list
branch
from
November 18, 2026 14:50
509d904 to
a501c9b
Compare
The interval id was stored in `getPagesIntervalId` but checked and cleared as `this.interval`, which was never set. Every offline/online switch started another interval, and leaving the collective only stopped the newest one. With notify_push, the 15 minute rate was set when the session started but not applied, so the page list was still polled every minute. Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5
`fetchPageContent()` returned `undefined` when the request failed, for example while offline. Opening a page then threw a TypeError on `trim()` and left an empty reader. Return `null` instead. The editor keeps its previous content and only opens empty pages in edit mode if their content was fetched. Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5
When the DAV request for a page or version fails, the print view printed the page with an empty body and the version view showed an empty version next to the restore button, without telling the user. Mark failed pages in the print view with an error note so the gap is visible in the preview and on paper, and show one error toast for all failed pages. Show an error state in the version view and disable restoring a version whose content could not be loaded. The error is shown by each caller rather than in `fetchPageContent()`, since the editor also refetches page content in the background and keeps the previous content if that fails. Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5
A page whose content could not be fetched, e.g. when opened while offline, showed an empty reader without any error. Nothing fetched the content again once the network was back, as the page timestamp didn't change, so the page looked empty until a reload. Show the offline state (or an error if online) in place of the reader and fetch the content again when the network comes back online. Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5
`setOffline` and `setOnline` each opened their own CDP session. Network emulation applies per session, so `setOnline` fired the browser's online event while requests stayed blocked by the session of `setOffline` until the end of the test. Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5
mejo-
force-pushed
the
fix/offline_page_list
branch
from
November 18, 2026 15:49
a501c9b to
b5a34fa
Compare
max-nextcloud
approved these changes
Nov 18, 2026
max-nextcloud
left a comment
Contributor
There was a problem hiding this comment.
Thanks for addressing all the feedback! Looks good now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Fixes two bugs around offline state handling.
See commit messages for details.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)🤖 AI (if applicable)