Skip to content

fix(service-worker): don't replace the cached app with redirects or shares - #2946

Merged
mejo- merged 1 commit into
mainfrom
fix/service_worker
Nov 18, 2026
Merged

mejo- merged 1 commit into
mainfrom
fix/service_worker

Conversation

@mejo-

@mejo- mejo- commented Nov 17, 2026

Copy link
Copy Markdown
Member

The navigation route cached every response under one key. A logged-out visit cached the redirect to the login page in place of the app, so the app could no longer be opened offline. Visiting a public share replaced the cached app with the share page.

  • Only cache navigation responses with status 200
  • Use a separate cache key per public share, and don't cache the share password form
  • Fall back to the cache when the server doesn't respond within 5 seconds

Assisted-by: ClaudeCode:claude-opus-5-5

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI tools
  • The AI-generated content was reviewed, comprehended and tested by a human

…hares

The navigation route cached every response under one key. A logged-out
visit cached the redirect to the login page in place of the app, so the
app could no longer be opened offline. Visiting a public share replaced
the cached app with the share page.

* Only cache navigation responses with status 200
* Use a separate cache key per public share, and don't cache the share
  password form
* Fall back to the cache when the server doesn't respond within 5 seconds

Signed-off-by: Jonas <jonas@freesources.org>
Assisted-by: ClaudeCode:claude-opus-5-5
@mejo- mejo- self-assigned this Nov 17, 2026
@mejo-
mejo- requested a review from max-nextcloud as a code owner November 17, 2026 09:56
@mejo- mejo- added the bug Something isn't working label Nov 17, 2026
@mejo-
mejo- requested a review from silverkszlo as a code owner November 17, 2026 09:56
@github-project-automation github-project-automation Bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Productivity team Nov 17, 2026
@mejo- mejo- moved this from 🧭 Planning evaluation (don't pick) to 👀 In review in 📝 Productivity team Nov 17, 2026
@mejo-
mejo- merged commit 9c2847e into main Nov 18, 2026
62 checks passed
@mejo-
mejo- deleted the fix/service_worker branch November 18, 2026 11:55
@github-project-automation github-project-automation Bot moved this from 👀 In review to ☑️ Done in 📝 Productivity team Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

2 participants