Repository navigation
fix(service-worker): don't replace the cached app with redirects or shares - #2946
Merged
Merged
Conversation
…hares The navigation route cached every response under one key. A logged-out visit cached the redirect to the login page in place of the app, so the app could no longer be opened offline. Visiting a public share replaced the cached app with the share page. * Only cache navigation responses with status 200 * Use a separate cache key per public share, and don't cache the share password form * Fall back to the cache when the server doesn't respond within 5 seconds Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5
max-nextcloud
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The navigation route cached every response under one key. A logged-out visit cached the redirect to the login page in place of the app, so the app could no longer be opened offline. Visiting a public share replaced the cached app with the share page.
Assisted-by: ClaudeCode:claude-opus-5-5
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)🤖 AI (if applicable)