Skip to content

Migrate off OCA.Viewer #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julien-nc merged 3 commits into from
Sep 29, 2026
Merged

Migrate off OCA.Viewer #670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f3b0d64
fix: migrate off OCA.Viewer in favour of @nextcloud/viewer
julien-nc Sep 28, 2026
c714012
fix: adjust psalm annotation of the saveOutputFile endpoint, regen op…
julien-nc Sep 28, 2026
734cee8
fix: add missing 'reasoning' attribute in response definition
julien-nc Sep 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/Controller/AssistantApiController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ public function shareOutputFile(int $ocpTaskId, int $fileId): DataResponse {
*
* @param int $ocpTaskId The task ID
* @param int $fileId The file ID
* @return DataResponse<Http::STATUS_OK, array{shareToken: string}, array{}>|DataResponse<Http::STATUS_NOT_FOUND, array{error: string}, array{}>
* @return DataResponse<Http::STATUS_OK, array{fileId: int, path: string, mime: string}, array{}>|DataResponse<Http::STATUS_NOT_FOUND, array{error: string}, array{}>
*
* 200: The file was saved
* 404: The file was not found
Expand Down
1 change: 1 addition & 0 deletions lib/ResponseDefinitions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@
* attachments: list<array{type: string, fileId: int}>,
* ocp_task_id: int,
* sources: string,
* reasoning: ?string,
* }
*
* @psalm-type AssistantChatAgencyMessage = AssistantChatMessage&array{
Expand Down
1 change: 1 addition & 0 deletions lib/Service/AssistantService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -749,6 +749,7 @@ public function saveOutputFile(string $userId, int $ocpTaskId, int $fileId): arr
return [
'fileId' => $fileCopy->getId(),
'path' => preg_replace('/^files\//', '/', $fileCopy->getInternalPath()),
'mime' => $fileCopy->getMimeType(),
];
}

Expand Down
20 changes: 17 additions & 3 deletions openapi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,8 @@
"timestamp",
"attachments",
"ocp_task_id",
"sources"
"sources",
"reasoning"
],
"properties": {
"id": {
Expand Down Expand Up @@ -145,6 +146,10 @@
},
"sources": {
"type": "string"
},
"reasoning": {
"type": "string",
"nullable": true
}
}
},
Expand Down Expand Up @@ -2189,10 +2194,19 @@
"data": {
"type": "object",
"required": [
"shareToken"
"fileId",
"path",
"mime"
],
"properties": {
"shareToken": {
"fileId": {
"type": "integer",
"format": "int64"
},
"path": {
"type": "string"
},
"mime": {
"type": "string"
}
}
Expand Down
Loading
Loading