feat(k8s): manage registry mappings in the admin UI - #1047
Conversation
1f07edb to
7e6577a
Compare
Signed-off-by: Oleksandr Piskun <oleksandr2088@icloud.com>
7e6577a to
7595243
Compare
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe Docker registries action now appears for daemons with Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The registry action is ready to merge after normal checks; no concrete issue remains from the expanded Kubernetes support or modal conversion. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Warning Some tools did not complete. Review the errors below. 🔧 ESLint
src/components/DaemonConfig/DaemonConfig.vueESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox. src/components/DaemonConfig/DockerRegistriesModal.vueESLint skipped: the matched ESLint configuration already failed (missing-dependency). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Follow-up to #1046, which makes the Kubernetes backend apply registry mappings. This branch is stacked on it and contains its commits until it is merged.
The "Docker registries" action of a deploy daemon was only offered for
docker-installdaemons. For Kubernetes daemons, mappings could only be managed with occ.Changes
kubernetes-installdaemons too. The dialog is generic and is reused as it is.registriesthroughObject.values(). A daemon that still has an object-shaped list stored (see fix(k8s): apply daemon registry mappings #1046) no longer breaks the add form.--color-warning-text.--color-warningis a background color and was hardly readable as text.No translatable string changes. "Image pull will be skipped" is true for Kubernetes daemons as well, since #1046 sends
imagePullPolicy: Neverfor alocalmapping.