Skip to content

feat(k8s): manage registry mappings in the admin UI - #1047

Merged
oleksandr-nc merged 1 commit into
mainfrom
feat/k8s-registry-mapping-ui
Sep 25, 2026
Merged

oleksandr-nc merged 1 commit into
mainfrom
feat/k8s-registry-mapping-ui

Conversation

@oleksandr-nc

@oleksandr-nc oleksandr-nc commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Follow-up to #1046, which makes the Kubernetes backend apply registry mappings. This branch is stacked on it and contains its commits until it is merged.

The "Docker registries" action of a deploy daemon was only offered for docker-install daemons. For Kubernetes daemons, mappings could only be managed with occ.

Changes

  • The action is shown for kubernetes-install daemons too. The dialog is generic and is reused as it is.
  • The dialog reads registries through Object.values(). A daemon that still has an object-shaped list stored (see fix(k8s): apply daemon registry mappings #1046) no longer breaks the add form.
  • The hint uses --color-warning-text. --color-warning is a background color and was hardly readable as text.

No translatable string changes. "Image pull will be skipped" is true for Kubernetes daemons as well, since #1046 sends imagePullPolicy: Never for a local mapping.

@oleksandr-nc
oleksandr-nc force-pushed the feat/k8s-registry-mapping-ui branch 4 times, most recently from 1f07edb to 7e6577a Compare September 25, 2026 08:27
Signed-off-by: Oleksandr Piskun <oleksandr2088@icloud.com>
@oleksandr-nc
oleksandr-nc force-pushed the feat/k8s-registry-mapping-ui branch from 7e6577a to 7595243 Compare September 25, 2026 09:09
@oleksandr-nc
oleksandr-nc marked this pull request as ready for review September 25, 2026 09:09
@coderabbitai

coderabbitai Bot commented Sep 25, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 329888f9-8d2b-49c4-80f4-59573ec6209f

📥 Commits

Reviewing files that changed from the base of the PR and between 3b08344 and 7595243.

⛔ Files ignored due to path filters (1)
  • js/app_api-adminSettings.js.map is excluded by !**/*.map
📒 Files selected for processing (3)
  • js/app_api-adminSettings.js
  • src/components/DaemonConfig/DaemonConfig.vue
  • src/components/DaemonConfig/DockerRegistriesModal.vue

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The Docker registries action now appears for daemons with docker-install or kubernetes-install as accepts_deploy_id. In the modal, the “Image pull will be skipped” warning uses the standard warning-text color. The registries property returns an array of configured values, or an empty array when no configuration is present.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 75952

The registry action is ready to merge after normal checks; no concrete issue remains from the expanded Kubernetes support or modal conversion.

Architecture Summary

Architecture risk: 🔵 Low · up to 75952

The change affects 1 system.

Changed systems: src

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — src (ui) was modified; 2 changed files map to changed impact.

Before / after behavior

  • observed — Modified behavior in src/components/DaemonConfig/DaemonConfig.vue: The Docker registries action now appears for both docker-install and kubernetes-install daemons instead of only docker-install.
  • observed — Modified behavior in src/components/DaemonConfig/DockerRegistriesModal.vue: The “Image pull will be skipped” warning changes from --color-warning to --color-warning-text.
  • observed — Modified behavior in src/components/DaemonConfig/DockerRegistriesModal.vue: registries now returns the values of the configured registry collection as an array instead of returning it directly; a missing configuration still yields an empty array.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: adding Kubernetes registry mapping management to the admin UI.
Description check ✅ Passed The description directly explains the Kubernetes registry mapping changes, UI behavior, data handling, and warning color update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Warning

Some tools did not complete. Review the errors below.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/components/DaemonConfig/DaemonConfig.vue

ESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox.

src/components/DaemonConfig/DockerRegistriesModal.vue

ESLint skipped: the matched ESLint configuration already failed (missing-dependency).


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@oleksandr-nc
oleksandr-nc merged commit 296cc1d into main Sep 25, 2026
56 checks passed
@oleksandr-nc
oleksandr-nc deleted the feat/k8s-registry-mapping-ui branch September 25, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant