Repository navigation
Prevent selection when Select is disabled before release - #136
Open
Xapollon430 wants to merge 1 commit into
Open
Xapollon430 wants to merge 1 commit into
Xapollon430 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
disabledtotrue, then release the mouse button.Orange becomes selected and
update:modelValuefires even though the component is disabled when the click completes. A pending option press keeps the dropdown open through the input's blur event.Watch the browser reproduction.
The Chromium recording uses the library's stylesheet and ordinary pointer input. It shows the same press and release on original and fixed Nextcloud Vue Select source. The app owns the value; the component owns the open state.
Check the current disabled prop before selecting an option or firing selection events. This is the same guard proposed for the Vue 2 upstream in sagalbot#1883, verified separately against this maintained Vue 3 fork.
Validation
AI-assisted implementation and testing.