Repository navigation
Conversation
nickvergessen
left a comment
There was a problem hiding this comment.
Did not execute, but looks good
|
Rector 2.8.2 removed its own `PhpDocNodeTraverser` in favour of the phpdoc-parser `NodeTraverser` and deprecated `PhpVersionFeature`. Assisted-by: ClaudeCode:claude-opus-5-5
Rector 2.8 turned `RenameStaticMethodRector` into a no-op, so the `OC_Helper` to `OCP\Util` migration needs its own rule. Assisted-by: ClaudeCode:claude-opus-5-5
Rector 2.8 removed `ClassNameImportSkipVoterInterface` without a replacement, so name imports can no longer be limited to Nextcloud namespaces. Assisted-by: ClaudeCode:claude-opus-5-5
93c8cfe to
b73b747
Compare
|
rebased ✅ |
|
Deps are not installable on PHP 8.1 and 8.2 🙈 |
|
No its unrelated to this PR, its broken since b9746d0 |
c82080f to
b73b747
Compare
|
Well we try to support 8.1: Line 51 in e67346a I guess we need to bump that to 8.2.35: https://github.com/Roave/SecurityAdvisories/blame/9f18043008504f654d3723c95346357a3af11deb/composer.json#L690 Edit: too slow |
Not really, back then Roave/SecurityAdvisory:latest still allowed PHP 8.1 |
|
Or we add https://github.com/nextcloud-libraries/rector/blob/main/.github/workflows/continuous-integration.yml#L151 everywhere and try if that works 🙈 |
|
see stack I created, I think this is the cleanest |
Rector 2.8 broke this library, and with it Nextcloud server's rector setup (nextcloud/server#66578):
AnnotationToAttributeRector: Rector 2.8.2 removedRector\PhpDocParser\PhpDocParser\PhpDocNodeTraverser. This switches to phpdoc-parser'sNodeTraverserwithCallablePhpDocNodeVisitor, the way upstream'sAnnotationToAttributeRectordoes now. It also replaces the deprecatedPhpVersionFeaturewithPhpVersion.rector/rectoris bumped to^2.8.2.OC_Helper→OCP\Util:RenameStaticMethodRectoris deprecated and now a no-op, so the Nextcloud 25 set silently stopped migrating these calls. It is replaced by a dedicatedOcHelperToOcpUtilRector.Breaking:
NextcloudNamespaceSkipVoteris removed. Rector 2.8.0 deletedClassNameImportSkipVoterInterface(Inline class-name import skip voters into ClassNameImportSkipper rectorphp/rector-src#8696) and offers no replacement, so imports can no longer be limited to Nextcloud namespaces.AI assisted