Skip to content

feat: allow to tell the Vue compiler about custom elements - #1087

Merged
susnux merged 1 commit into
mainfrom
feat/is-custom-element
Oct 21, 2026
Merged

susnux merged 1 commit into
mainfrom
feat/is-custom-element

Conversation

@skjnldsv

Copy link
Copy Markdown
Contributor

Apps can't set the Vue plugin's isCustomElement, because the plugin is created here with fixed options. So a custom element in a template, like <nc-viewer-file> from @nextcloud/viewer, gets resolved as a component and Vue warns on every render. The server works around it with <component :is> (nextcloud/server#65753), and the viewer library patches the plugin's options in configResolved.

createAppConfig(entries, { isCustomElement: (tag) => tag === 'nc-viewer-file' })

Covered by a node test on the resolved plugin options. Would be great to have on stable2 too, since that's what server uses.

👾 This pull request was assisted by Claude Code, commits carry an Assisted-by trailer.

An app had no way to set the Vue plugin's isCustomElement: the plugin
is created here with fixed options. Without it, a custom element in a
template, as <nc-viewer-file> from @nextcloud/viewer, is resolved as a
component, which warns on every render.

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
@skjnldsv skjnldsv added type: enhancement 🚀 New feature or request 3. to review 3️⃣ Waiting for reviews backport-request AI assisted This PR contains AI-assisted commits labels Oct 21, 2026
@skjnldsv skjnldsv self-assigned this Oct 21, 2026
@skjnldsv
skjnldsv requested a review from susnux October 21, 2026 12:25
@susnux
susnux merged commit 3c2cb20 into main Oct 21, 2026
10 checks passed
@susnux
susnux deleted the feat/is-custom-element branch October 21, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review 3️⃣ Waiting for reviews AI assisted This PR contains AI-assisted commits backport-request type: enhancement 🚀 New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants