Repository navigation
feat: allow to tell the Vue compiler about custom elements - #1087
Merged
Merged
Conversation
An app had no way to set the Vue plugin's isCustomElement: the plugin is created here with fixed options. Without it, a custom element in a template, as <nc-viewer-file> from @nextcloud/viewer, is resolved as a component, which warns on every render. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
susnux
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apps can't set the Vue plugin's
isCustomElement, because the plugin is created here with fixed options. So a custom element in a template, like<nc-viewer-file>from @nextcloud/viewer, gets resolved as a component and Vue warns on every render. The server works around it with<component :is>(nextcloud/server#65753), and the viewer library patches the plugin's options inconfigResolved.Covered by a node test on the resolved plugin options. Would be great to have on stable2 too, since that's what server uses.
👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.