Skip to content

fix(dialog): name the sharee "recipient" everywhere - #288

Merged
skjnldsv merged 1 commit into
mainfrom
fix/unify-recipient-wording
Sep 9, 2026
Merged

skjnldsv merged 1 commit into
mainfrom
fix/unify-recipient-wording

Conversation

@skjnldsv

@skjnldsv skjnldsv commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

The dialog called the same thing people, participants and recipients. Settled on recipient, which the API and the code already use:

  • "Add people" → "Add recipient"
  • "Remove participant" → "Remove recipient"
  • "Switching to a public link removes %n invited person/people from this share." → "…removes %n recipient/recipients…"

"Note to recipients" comes from the backend property, so it is already right.

Fixes #279

One I did not touch: the "Invited people" tab. It labels a share type rather than the sharee, and it pairs with "Anyone", so renaming it looked like a design call rather than a wording cleanup — @susnux @kra-mo, say the word and I will fold it in.

The files_sharing sidebar in server has its own "Remove participant" that should follow; I can do that once this lands.

👾 This pull request was assisted by Claude Code, commits carry an Assisted-by trailer.

The dialog called the same thing people, participants and recipients. Settle on
recipient, which the API and the code already use.

The "Invited people" tab keeps its name for now: it labels a share type rather
than the sharee, and renaming it is a design call.

Assisted-by: ClaudeCode:claude-opus-4-8
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added the bug Something isn't working label Sep 9, 2026
@codecov

codecov Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.91%. Comparing base (6e6c125) to head (60dc772).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #288   +/-   ##
=======================================
  Coverage   79.91%   79.91%           
=======================================
  Files          27       27           
  Lines         727      727           
  Branches      202      202           
=======================================
  Hits          581      581           
  Misses        127      127           
  Partials       19       19           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@skjnldsv
skjnldsv merged commit 21a8f6b into main Sep 9, 2026
15 checks passed
@skjnldsv
skjnldsv deleted the fix/unify-recipient-wording branch September 9, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent wording for sharee

1 participant