Skip to content

fix(dialog): close the recipient menu when the permissions modal opens #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 1 commit into from
Sep 9, 2026
Merged

fix(dialog): close the recipient menu when the permissions modal opens #286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/dialog/components/RecipientRow.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
</template>
{{ preset.label }}
</NcActionButton>
<NcActionButton @click="modalOpen = true">
<NcActionButton closeAfterClick @click="modalOpen = true">
<template #icon>
<NcIconSvgWrapper v-if="isCustom" :svg="IconCheck" :size="20" />
</template>
Expand Down
2 changes: 2 additions & 0 deletions tests/ct/RecipientRow.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,6 @@ test('opens the custom permissions modal from the menu', async ({ mount, page })
await component.getByRole('button', { name: 'Recipient actions' }).click()
await page.getByRole('menuitem', { name: 'Custom permissions' }).click()
await expect(page.getByRole('dialog')).toBeVisible()
// The menu has to get out of the way, or it overlaps the modal it opened.
await expect(page.getByRole('menu')).toHaveCount(0)
})
Loading