Conversation
`readEntries()` was only called once, but Chromium returns at most 100 entries per call, so folders with more entries silently lost files. The `FileSystemEntry` guards additionally used `instanceof`, which never matches in Chromium as it does not expose those legacy interfaces as globals, so dropped folders were treated as plain files altogether. Call `readEntries()` until it returns an empty array, and detect entries by their shape instead of `instanceof`. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
added
type: bug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1748 +/- ##
==========================================
+ Coverage 87.95% 89.04% +1.09%
==========================================
Files 44 44
Lines 1129 1132 +3
Branches 281 284 +3
==========================================
+ Hits 993 1008 +15
+ Misses 101 92 -9
+ Partials 35 32 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
skjnldsv
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
readEntries()was only called once, but Chromium returns at most 100 entries per call, so folders with more entries silently lost files.The
FileSystemEntryguards additionally usedinstanceof, which never matches in Chromium as it does not expose those legacy interfaces as globals, so dropped folders were treated as plain files altogether.Solution
Call
readEntries()until it returns an empty array, and detect entries by their shape instead ofinstanceof.🤖 AI (if applicable)