fix(upload): make the signal upload option actually cancel the upload - #1747
Merged
Merged
Conversation
susnux
added
type: bug
Both upload paths registered `upload.cancel` unbound as the `abort` listener. `cancel()` reads the private `#abortController`, so with `this` being the `AbortSignal` it threw instead of cancelling — and as it threw inside a listener, the upload silently kept running. An already aborted signal did nothing at all, since the listener never fires. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1747 +/- ##
==========================================
+ Coverage 87.55% 87.95% +0.39%
==========================================
Files 44 44
Lines 1125 1129 +4
Branches 280 281 +1
==========================================
+ Hits 985 993 +8
+ Misses 103 101 -2
+ Partials 37 35 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
skjnldsv
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both upload paths registered
upload.cancelunbound as theabortlistener.cancel()reads the private#abortController, so withthisbeing theAbortSignalit threw instead of cancelling — and as it threw inside a listener, the upload silently kept running. An already aborted signal did nothing at all, since the listener never fires.🤖 AI (if applicable)