fix(upload): do not finish chunked uploads after the first chunk - #1746
Merged
Merged
Conversation
`#uploadChunk` is shared by the chunked and non-chunked path, but set `uploadedBytes` to the full file size and the status to `FINISHED` once its chunk was acknowledged. For a chunked upload this happened for every chunk: the reported progress exceeded 100% (~130% for a 21 MiB file), the upload was `FINISHED` while still uploading and assembling, a failed chunk was flipped back to `FINISHED` by the next successful one, and `Uploader.reset()` skipped the upload as it "is finished". Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
added
type: bug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1746 +/- ##
==========================================
+ Coverage 87.18% 87.55% +0.36%
==========================================
Files 44 44
Lines 1116 1125 +9
Branches 280 280
==========================================
+ Hits 973 985 +12
+ Misses 107 103 -4
- Partials 36 37 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
skjnldsv
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#uploadChunkis shared by the chunked and non-chunked path, but setuploadedBytesto the full file size and the status toFINISHEDonce its chunk was acknowledged.For a chunked upload this happened for every chunk: the reported progress exceeded 100% (~130% for a 21 MiB file), the upload was
FINISHEDwhile still uploading and assembling, a failed chunk was flipped back toFINISHEDby the next successful one, andUploader.reset()skipped the upload as it "is finished".🤖 AI (if applicable)