fix(upload): propagate folder renames to already initialized child uploads - #1744
Merged
Merged
Conversation
…loads The whole upload tree is initialized upfront, so children are created with the original folder names, while conflicts are resolved later per level. Renaming a directory therefore only updated that node's source and its descendants kept uploading into the conflicting folder. Replace the `source` patching with a `rebase()` method on `Upload`, which `UploadFileTree` overrides to also move all of its children. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
added
type: bug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1744 +/- ##
==========================================
+ Coverage 87.37% 87.42% +0.04%
==========================================
Files 44 44
Lines 1117 1121 +4
Branches 281 281
==========================================
+ Hits 976 980 +4
Misses 105 105
Partials 36 36 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The whole upload tree is initialized upfront, so children are created with the original folder names, while conflicts are resolved later per level. Renaming a directory therefore only updated that node's source and its descendants kept uploading into the conflicting folder.
Replace the
sourcepatching with arebase()method onUpload, whichUploadFileTreeoverrides to also move all of its children.🤖 AI (if applicable)