Skip to content

fix(uploader): properly handle chunked uploads - #1686

Merged
susnux merged 2 commits into
mainfrom
fix/chunking
Jul 9, 2026
Merged

susnux merged 2 commits into
mainfrom
fix/chunking

Conversation

@susnux

@susnux susnux commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

After some tests in apps discovered that chunking was not properly working:

  • join of absolute URL vs absolute path
  • double added queue jobs
  • chunk slices

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@susnux susnux added type: bug 🐛 Something isn't working 3. to review 3️⃣ Waiting for reviews labels Jul 6, 2026
@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.93%. Comparing base (3eb88af) to head (21f8a17).

Files with missing lines Patch % Lines
lib/upload/utils/upload.ts 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1686      +/-   ##
==========================================
+ Coverage   85.15%   85.93%   +0.77%     
==========================================
  Files          44       44              
  Lines        1098     1102       +4     
  Branches      274      275       +1     
==========================================
+ Hits          935      947      +12     
+ Misses        127      117      -10     
- Partials       36       38       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

susnux added 2 commits July 8, 2026 19:44
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
susnux merged commit 6629be3 into main Jul 9, 2026
13 checks passed
@susnux
susnux deleted the fix/chunking branch July 9, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review 3️⃣ Waiting for reviews type: bug 🐛 Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants