Skip to content

Darkly nr integration - #1837

Open
hmstepanek wants to merge 17 commits into
develop-launch-darkly-integrationfrom
darkly-nr-integration
Open

Darkly nr integration#1837
hmstepanek wants to merge 17 commits into
develop-launch-darkly-integrationfrom
darkly-nr-integration

Conversation

@hmstepanek

Copy link
Copy Markdown
Contributor

Overview

Add Launch Darkly feature flag information to New Relic spans & send OTel version of New Relic spans to Launch Darkly.

@hmstepanek
hmstepanek requested a review from a team as a code owner August 26, 2026 21:08
@github-actions

github-actions Bot commented Aug 26, 2026

Copy link
Copy Markdown

MegaLinter analysis: Error

Descriptor Linter Files Fixed Errors Max errors Warnings Elapsed time
✅ ACTION actionlint 9 0 0 1.04s
✅ MARKDOWN markdownlint 7 0 0 0 1.22s
❌ PYTHON ruff 1108 3 1 0 1.03s
✅ PYTHON ruff-format 1108 5 0 0 0.24s
✅ YAML prettier 23 0 0 0 1.34s
✅ YAML v8r 23 0 0 5.96s
✅ YAML yamllint 23 0 0 1.0s

Detailed Issues

❌ PYTHON / ruff - 1 error
::error title=ruff (PLW0602),file=newrelic/hooks/observability_ldclient.py,line=82,col=12,endLine=82,endColumn=43::newrelic/hooks/observability_ldclient.py:82:12: PLW0602 Using global for `OBSERVABILITY_PLUGIN_REGISTERED` but no assignment is done

See detailed reports in MegaLinter artifacts

MegaLinter is provided by OX Security
Show us your support by starring ⭐ the repository

@mergify mergify Bot added the merge-conflicts Merge conflicts detected. label Aug 26, 2026
@hmstepanek
hmstepanek force-pushed the darkly-nr-integration branch from e42753a to e397922 Compare August 26, 2026 21:23
@mergify mergify Bot added tests-failing Tests failing in CI. and removed merge-conflicts Merge conflicts detected. labels Aug 26, 2026
@codecov-commenter

codecov-commenter commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 58.88889% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.00%. Comparing base (44c3db2) to head (c2e1c24).

Files with missing lines Patch % Lines
newrelic/hooks/observability_ldclient.py 69.23% 11 Missing and 9 partials ⚠️
newrelic/core/stats_engine.py 0.00% 16 Missing and 1 partial ⚠️
Additional details and impacted files
@@                          Coverage Diff                          @@
##           develop-launch-darkly-integration    #1837      +/-   ##
=====================================================================
- Coverage                              82.14%   82.00%   -0.14%     
=====================================================================
  Files                                    220      221       +1     
  Lines                                  27344    27434      +90     
  Branches                                4330     4346      +16     
=====================================================================
+ Hits                                   22461    22498      +37     
- Misses                                  3378     3414      +36     
- Partials                                1505     1522      +17     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hmstepanek
hmstepanek force-pushed the darkly-nr-integration branch from d87fde6 to c2e1c24 Compare August 28, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests-failing Tests failing in CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants