chore: Initial work to add agent config schema - #1741
Open
mvicknr wants to merge 68 commits into
Open
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
✅MegaLinter analysis: Success
See detailed reports in MegaLinter artifacts
|
Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1741 +/- ##
==========================================
- Coverage 82.14% 82.12% -0.02%
==========================================
Files 220 220
Lines 27344 27344
Branches 4330 4330
==========================================
- Hits 22461 22457 -4
- Misses 3378 3380 +2
- Partials 1505 1507 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude <noreply@anthropic.com>
Pre-applies the YAML formatting that MegaLinter's YAML_PRETTIER would otherwise auto-fix. The auto-commit step in mega-linter.yml uses the default GITHUB_TOKEN, which cannot push changes to .github/workflows/* files (GitHub blocks workflow modifications without the 'workflow' PAT scope). Applying the fixes locally lets CI's auto-commit be a no-op.
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Collaborator
Author
|
this commit shows that the schema generation on push works: chore: regenerate Fleet Control config schema |
mvicknr
commented
Aug 20, 2026
| "type": "string", | ||
| "description": "Sets the name of a file to log agent messages to. Whatever you set this to, you must ensure that the permissions for the containing directory and the file itself are correct, and that the user that your web application runs as can write out to the file. If not able to out a log file, it is also possible to say \"stderr\" and output to standard error output. This would normally result in output appearing in your web server log. It can also be set using the NEW_RELIC_LOG environment variable." | ||
| }, | ||
| "log_level": { |
Collaborator
Author
There was a problem hiding this comment.
other agents are not using an enum here because enum forces case sensitivity - should I update this to a string for you as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds a script to automatically generate and update a configuration schema for the agent. This PR has the initial schema generated from the script.
The script will automatically run on local build and on pushes. It will determine if there are config changes and if so, it will update the schema. On local, the dev should include these changes in their commit. On push, if the changes aren't already made in the schema, it will make the changes and add them to the PR.
The schema version will be updated as part of the regular agent release. - This will need to happen after the release tag has been generated but before it has been applied.
See the readme in the schemaGeneration directory to understand how the schema is generated.
Testing
The agent includes a suite of tests which should be used to
verify your changes don't break existing functionality. These tests will run with
Github Actions when a pull request is made. More details on running the tests locally can be found in our
testing guidelines,
For most contributions it is strongly recommended to add additional tests which
exercise your changes.