Skip to content

fix: set github_token for zizmor #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olblak merged 1 commit into from
Sep 10, 2026
Merged

fix: set github_token for zizmor #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/updatecli.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ permissions: {}
jobs:
updatecli:
runs-on: ubuntu-latest
permissions:
contents: "read"
steps:
- name: "Checkout"
uses: "actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1" # v7.0.1
Expand Down Expand Up @@ -40,7 +42,7 @@ jobs:
UPDATECLI_UDASH_API_URL: ${{ secrets.UPDATECLI_UDASH_API_URL }}
UPDATECLI_UDASH_ACCESS_TOKEN: ${{ secrets.UPDATECLI_UDASH_ACCESS_TOKEN }}
UPDATECLI_UDASH_URL: ${{ secrets.UPDATECLI_UDASH_URL }}
## The Github token seems to be needed by Zizmor
## The Github token is needed by Zizmor
# https://github.com/updatecli/policies/blob/main/updatecli/policies/zizmor/githubaction/scaffold/updatecli.d/default.yaml#L106
# Adding for now just for testing
GITHUB_TOKEN: ""
GITHUB_TOKEN: " ${{ secrets.GITHUB_TOKEN }}"
8 changes: 4 additions & 4 deletions .github/workflows/updatecli_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ permissions:
jobs:
updatecli:
runs-on: ubuntu-latest
permissions:
contents: read
steps:
- name: "Checkout"
uses: "actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1" # v7.0.1
Expand Down Expand Up @@ -35,7 +37,5 @@ jobs:
# This step is executed in untrusted context. We use a GitHub token with minimal permissions.
UPDATECLI_GITHUB_USERNAME: ${{ github.actor }}
UPDATECLI_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
## The Github token seems to be needed by Zizmor
# https://github.com/updatecli/policies/blob/main/updatecli/policies/zizmor/githubaction/scaffold/updatecli.d/default.yaml#L106
# Adding for now just for testing
GITHUB_TOKEN: ""
## The Github token is needed by Zizmor
GITHUB_TOKEN: " ${{ secrets.GITHUB_TOKEN }}"
8 changes: 4 additions & 4 deletions .github/workflows/updatecli_update.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ jobs:
apply_args: "--labels=monitor:active"
- target_name: "existing pipelines"
apply_args: "--existing-only=true"
permissions:
contents: read
steps:
- name: "Checkout"
uses: "actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1" # v7.0.1
Expand Down Expand Up @@ -52,7 +54,5 @@ jobs:
UPDATECLI_UDASH_API_URL: ${{ secrets.UPDATECLI_UDASH_API_URL }}
UPDATECLI_UDASH_ACCESS_TOKEN: ${{ secrets.UPDATECLI_UDASH_ACCESS_TOKEN }}
UPDATECLI_UDASH_URL: ${{ secrets.UPDATECLI_UDASH_URL }}
## The Github token seems to be needed by Zizmor
# https://github.com/updatecli/policies/blob/main/updatecli/policies/zizmor/githubaction/scaffold/updatecli.d/default.yaml#L106
# Adding for now just for testing
GITHUB_TOKEN: ""
## The Github token is needed by Zizmor
GITHUB_TOKEN: " ${{ secrets.GITHUB_TOKEN }}"