ci: update actions off the deprecated Node 20 runtime - #122
Merged
Conversation
Every run of all three workflows warns that actions/checkout@v4, actions/setup-node@v4 and pnpm/action-setup@v4 target Node 20 and are being forced onto Node 24. That fallback is temporary; when it goes, CI and the nightly registry publish go with it. The pins were three majors behind: checkout and setup-node v4 -> v7, cache v4 -> v6, pnpm/action-setup v4 -> v6. Deliberately does NOT touch `node-version: '20'`, which is the Node the project itself builds and tests on. That is a separate and riskier change: better-sqlite3 has already been observed failing against a newer Node in this repo, so moving it needs its own PR with the native rebuild verified. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NBQQpA86yYzwJUiVz8ph2R
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every run of all three workflows emits:
That forced fallback is temporary. When GitHub drops it, CI and the nightly registry publish stop working — and the pins were three majors behind:
actions/checkoutactions/setup-nodeactions/cachepnpm/action-setupchangesets/action@v1is unchanged — it doesn't use thevNtag scheme and isn't in the warning.What this deliberately does NOT change
node-version: '20'stays as-is in all five places. That's the Node the project itself builds, tests and publishes on, and it's a separate, riskier change:better-sqlite3has already been observed failing against a newer Node in this repo (a contributor's "40 pre-existing failures" on #117 turned out to be Node v26 vsbetter-sqlite311.10.0). Node 20 is EOL and should move, but it needs its own PR with the native rebuild actually verified — not a blind bump bundled into this one.Test plan
ci.ymlis fully exercised by this PR's own checks (Lint, Build, Test)release.ymlandregistry-update.ymlare not reachable from PR CIFor the second row I'll dispatch
registry-update.ymlfrom this branch with{"since": "2"}— the same argument shape the schedule uses — so the nightly path is proven before merge rather than discovered at 06:30 UTC.Generated by Claude Code