fix(registry): stop sanity v4 releases failing the nightly publish - #121
Merged
Conversation
The definition claimed min_version 3.0.0, but sanity's v3 and v4 lines have no docs/ directory at all. Sanity still ships v4 maintenance releases, and each one took down the entire nightly run for all 140 packages with "Directory not found: /tmp/context-git-XXXXXX/docs" — most recently npm/sanity@4.22.1 on Aug 20 and Aug 21. The run went green again on Aug 22 only because --since 2 stopped selecting 4.22.1 once it aged out of the window. Nothing was fixed; the next v4 release would have failed the same way. docs/ first appears in v5. Verified by building each line: v6.11.0 -> 31 sections v5.31.2 -> 23 sections v4.22.1 -> no version entry matches, so version-check.ts filters it out before the build rather than throwing. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NBQQpA86yYzwJUiVz8ph2R
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The nightly registry publish failed on Aug 20 and Aug 21:
One failed definition exits the whole run non-zero, so all 140 packages were affected.
The run went green again on Aug 22, but nothing had been fixed.
publish-all --since 2only selects versions published in the last two days; once 4.22.1 aged out of that window it stopped being built and the error disappeared. The next v4 release would have failed identically.Root cause
The definition declared
min_version: "3.0.0", butdocs/only exists from v5 onward. Sanity maintains v4, v5 and v6 in parallel and still ships v4 maintenance releases, so any of them hits a missing directory.docs/Fix
Raise the floor to
5.0.0. Verified locally: 6.11.0 and 5.31.2 build; 4.22.1 now returnsNo version entry matches 4.22.1 in sanity, andversion-check.ts:96filters unmatched versions out before the build rather than throwing — so the nightly skips it cleanly instead of failing.Worth a follow-up (not in this PR)
Even where it works, this package is thin:
docs/holds 3 internal developer notes (CORE_CONCEPTS.md,STEGA.md,TELEMETRY.md), not Sanity's user documentation, which lives at sanity.io/docs. Byregistry/README.md's own rule of thumb — "a few hundred sections meansdocs_pathis right; a handful usually means it's pointing at the wrong directory" — 31 sections says this is the wrong source.Sanity publishes an
llms.txt(https://www.sanity.io/llms.txtreturns 200), but registry definitions only supportgitandzipsources, so pointing at it needs a new source type rather than a config change.Test plan
registry build sanity 6.11.0→ 31 sectionsregistry build sanity 5.31.2→ 23 sectionsregistry build sanity 4.22.1→ cleanly excludedGenerated by Claude Code