Skip to content

NPS-D: remove sudo from docker login in AWS configuration#932

Merged
TM-PO-Netwrix merged 2 commits into
devfrom
tm-npsd
May 15, 2026
Merged

NPS-D: remove sudo from docker login in AWS configuration#932
TM-PO-Netwrix merged 2 commits into
devfrom
tm-npsd

Conversation

@TM-PO-Netwrix
Copy link
Copy Markdown
Contributor

Summary

  • Removed sudo from the docker login command in the AWS configuration guide — the command should run as the current user, not root, consistent with the secureone.sh help output

Test plan

  • Verify docker login command in awsconfiguration.md has no sudo
  • Confirm build passes

Generated with AI

Co-Authored-By: Claude Code ai@netwrix.com

Generated with AI

Co-Authored-By: Claude Code <ai@netwrix.com>
@TM-PO-Netwrix TM-PO-Netwrix requested a review from a team as a code owner May 15, 2026 14:45
@github-actions
Copy link
Copy Markdown
Contributor

Documentation PR Review

Editorial Review

docs/privilegesecurediscovery/2.22/installation/containerbaseddeployment/awsconfiguration.md

  • No issues found.

The change removes sudo from the docker login command in a code block. The surrounding prose, structure, and context are unaffected and remain clear and complete.

Summary

0 editorial suggestions across 1 file. Vale and Dale issues are auto-fixed separately.


What to do next:

Comment @claude on this PR followed by your instructions to get help:

  • @claude fix all issues — fix all editorial issues
  • @claude help improve the flow of this document — get writing assistance
  • @claude explain the voice issues — understand why something was flagged

You can ask Claude anything about the review or about Netwrix writing standards.

Automated fixes are only available for branches in this repository, not forks.

@github-actions
Copy link
Copy Markdown
Contributor

Auto-Fix Summary

2 issues fixed, 2 skipped across 1 files

Category Fixes
Dale: passive-voice 1
Dale: undefined-acronyms 1
Skipped (needs manual review) Reason

| docs/privilegesecurediscovery/2.22/installation/containerbaseddeployment/awsconfiguration.md:30 — Dale: passive-voice | 'When prompted:' is a common, accepted shorthand for procedural docs; rewriting changes the structure of the table introduction |
| docs/privilegesecurediscovery/2.22/installation/containerbaseddeployment/awsconfiguration.md:50 — Dale: wordiness | 'confirms the authentication was successful' is slightly wordy but clear; multiple valid rewrites with no clear winner |

Ask @claude on this PR if you'd like an explanation of any fix.

@TM-PO-Netwrix TM-PO-Netwrix merged commit b3c824c into dev May 15, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants