[NAE-2461] Create case filter only deployed#343
Conversation
- add deployment state in petri-net-reference.ts - add filter on create case to filter only deployed nets
WalkthroughChangesThe PR adds deployment-state data to petri-net references and Deployment state contract and Net storage
Case creation lifecycle and filtering
Deployment state in fixtures and examples
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- update tests
- fix memory leaks in case-view-service.ts - fix deprecated use of subscribe method
- fix missing import
|
@coderabbitai review this PR |
|
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@projects/netgrif-components-core/src/lib/header/case-header/case-header.service.spec.ts`:
- Line 37: Update the DeploymentState import in the case-header service spec to
use single quotes instead of double quotes, matching the existing import style
in the file.
In
`@projects/netgrif-components-core/src/lib/view/case-view/service/case-view-service.ts`:
- Line 296: Update createDefaultNewCase to return myCase.asObservable() instead
of the raw Subject, matching createNewCase and preventing callers from accessing
Subject mutation methods.
- Around line 264-296: Ensure the myCase Subject is completed on every failure
path in createDefaultNewCase: call myCase.complete() before returning when no
nets are available, and after handling errors in both the createCase and
getNewCaseAllowedNets subscriptions. Keep the existing success completion
unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 42804f79-66af-4a19-838b-66a30370d6d5
📒 Files selected for processing (13)
projects/nae-example-app/src/app/doc/panels/panels.component.tsprojects/nae-example-app/src/app/doc/sidemenu-example/sidemenu-example.component.tsprojects/netgrif-components-core/src/lib/authorization/permission/permission.service.spec.tsprojects/netgrif-components-core/src/lib/header/case-header/case-header.service.spec.tsprojects/netgrif-components-core/src/lib/panel/workflow-panel/abstract-workflow-panel.component.spec.tsprojects/netgrif-components-core/src/lib/process/net.spec.tsprojects/netgrif-components-core/src/lib/process/net.tsprojects/netgrif-components-core/src/lib/resources/interface/petri-net-reference.tsprojects/netgrif-components-core/src/lib/utility/tests/utility/create-mock-net.tsprojects/netgrif-components-core/src/lib/view/case-view/service/case-view-service.tsprojects/netgrif-components-core/src/lib/view/tree-case-view/tree-component/case-tree.service.spec.tsprojects/netgrif-components/src/lib/panel/public-workflow-panel/public-workflow-panel.component.spec.tsprojects/netgrif-components/src/lib/panel/workflow-panel/workflow-panel.component.spec.ts
- fix subject completion - fix return value encapsulation - fix imports
|
The base branch was changed.



Description
Implements NAE-2461
Dependencies
No new dependencies were introduced
Third party dependencies
No new dependencies were introduced
Blocking Pull requests
There are no dependencies on other PR
How Has Been This Tested?
Manually and by unit tests
Test Configuration
Checklist:
Summary by CodeRabbit
New Features
Bug Fixes