Skip to content

Improve Algorithms (testers) - #431

Merged
Ferroin merged 14 commits into
netdata:masterfrom
thiagoftsm:improve_algs
Sep 18, 2026
Merged

Ferroin merged 14 commits into
netdata:masterfrom
thiagoftsm:improve_algs

Conversation

@thiagoftsm

@thiagoftsm thiagoftsm commented May 25, 2026

Copy link
Copy Markdown
Contributor
Summary

While during tests with netdata/netdata#22469 some issues were detected. This PR fixes them in this repo.

Test Plan
  1. Get binaries according to your C library from [this](ADD ACTIONS LINK HERE) link and extract them inside a directory, for example: ../artifacts.
    You can also get everything for glibc [here](UPLOAD FILE WITH ALL BINARIES TO SIMPLIFY REVIEWERS).

  2. Extract them running:

    $ for i in `ls *.zip`; do unzip $i; rm .gitkeep ; rm $i; done
    $ for i in `ls *.tar`; do tar -xf $i; rm $i* ; done
  3. Compile branch an run the following tests:

    # make clean; make tester
    # for i in `seq 0 3`; do ./tests/legacy_test --netdata-path ../artifacts --content --iteration 1 --pid $i --log-path file_c_pid$i.txt; done
    # for i in `seq 0 3`; do ./gotests/go_tester --netdata-path ../artifacts --content --iteration 1 --pid $i --log-path file_go_pid$i.txt; done
  4. Every test should ends with Success, unless you do not have a specific target (function) available.

Additional information

This PR was tested on:

Linux Distribution Environment Kernel Version
Slackware Current Bare metal 6.18.51
Arch Linux VM 7.2.6-arch2-1
Debian 12 VM 6.12.107+deb13
Alma 9 VM 5.14.0-687.el9_8
Alma 8 VM 4.18

@thiagoftsm
thiagoftsm marked this pull request as ready for review May 27, 2026 13:12
@thiagoftsm
thiagoftsm requested a review from Ferroin as a code owner May 27, 2026 13:12
@thiagoftsm thiagoftsm closed this Sep 16, 2026
@thiagoftsm thiagoftsm reopened this Sep 16, 2026
@thiagoftsm
thiagoftsm requested a review from stelfrag September 18, 2026 02:37
@Ferroin
Ferroin merged commit d2d19b2 into netdata:master Sep 18, 2026
41 checks passed
@thiagoftsm
thiagoftsm deleted the improve_algs branch September 18, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants