Persist accepted session input before acknowledgment - #2209
Open
Aaronontheweb wants to merge 1 commit into
Open
Aaronontheweb wants to merge 1 commit into
Aaronontheweb wants to merge 1 commit into
Conversation
Aaronontheweb
added this pull request to stack #2212
September 19, 2026 13:58
Aaronontheweb
marked this pull request as ready for review
September 19, 2026 14:16
| public static string? SourceMessageKey(InputAdmitted evt) | ||
| => string.IsNullOrWhiteSpace(evt.SourceMessageId) | ||
| ? null | ||
| : $"{evt.TurnContext?.ChannelType ?? string.Empty}:{evt.TurnContext?.RequesterSenderId?.Value ?? string.Empty}:{evt.SourceMessageId}"; |
| SessionId = _sessionId, | ||
| InputId = Guid.NewGuid().ToString("N"), | ||
| SourceMessageId = cmd.Source?.MessageId | ||
| ?? cmd.Source?.ReminderId?.Value |
| InputId = Guid.NewGuid().ToString("N"), | ||
| SourceMessageId = cmd.Source?.MessageId | ||
| ?? cmd.Source?.ReminderId?.Value | ||
| ?? cmd.Source?.BackgroundJobId?.Value, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
This PR adds the journal foundation for restart recovery. It stacks on #2202.
TurnRecordedandToolBatchStartedfields for journal compatibility.The OpenSpec change describes the complete recovery contract. This PR implements its admission foundation. The next stacked PR adds stop classification, the bounded manifest, and automatic wakeup. This PR does not resume a model call after a daemon restart.
Evidence
Netclaw.Actors.Tests: 4,025 passed, six skipped.dotnet slopwatch analyze: zero issues.openspec validate resume-interrupted-sessions --strict, andgit diff --checkpassed.Review focus
Check the input ack boundary, event replay, old journal compatibility, and source scope for deduplication.
This PR replaces #2204 so GitHub can link the same-repository branches as a stack.