Stop durable approval waits during daemon drain - #2208
Open
Aaronontheweb wants to merge 2 commits into
Open
Aaronontheweb wants to merge 2 commits into
Aaronontheweb wants to merge 2 commits into
Conversation
Aaronontheweb
added this pull request to stack #2212
September 19, 2026 13:58
Aaronontheweb
marked this pull request as ready for review
September 19, 2026 14:16
Aaronontheweb
added
sessions
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Comment on lines
+5019
to
+5022
| catch (Exception ex) | ||
| { | ||
| actor.Tell(new ToolPipelineStoppedForRestart(generation, ex)); | ||
| } |
Comment on lines
+102
to
+111
| foreach (var callId in _expectedCallIds) | ||
| { | ||
| if (_completedCallIds.Contains(callId)) | ||
| continue; | ||
|
|
||
| if (!hasDurableApproval(callId)) | ||
| return false; | ||
|
|
||
| hasUnfinishedApproval = true; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Evidence
Scope
The actor still uses the current drain limit for active model calls and other tool states. The later input recovery PR addresses those states. No live daemon restart took place.
Stack
This PR targets the approved plan in #2201.
This PR replaces #2202 so GitHub can link the same-repository branches as a stack.