Bound graceful daemon stop to thirty seconds - #2206
Closed
Aaronontheweb wants to merge 1 commit into
Closed
Aaronontheweb wants to merge 1 commit into
Aaronontheweb wants to merge 1 commit into
Conversation
Collaborator
Author
|
Superseded by #2211. The new PR uses the same commit and belongs to native stack #2212. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Reason
The prior 190 second drain bound waited for work that could not finish during shutdown. The preceding PRs persist accepted input and confirm model cancellation before they grant a resume candidate. The shorter limit caps a stalled stop. A tool with an uncertain external effect remains quiet after the limit; Netclaw does not replay it automatically.
Evidence
deepseek-v4-flash-dspark(run096fdfca-31ac-4dc3-8cbd-47e39b6ce9ac).0600manifest. The second stop retained the earlier candidate and added the new one.The normal stop path showed no meaningful speed change. The new limit reduces the maximum wait for a stalled drain. The active daemon on this machine was not restarted.
Stack
Base: #2205. Merge this PR after #2205.