Skip to content

Reuse shell approvals after bare status output - #2200

Merged
Aaronontheweb merged 2 commits into
netclaw-dev:devfrom
Aaronontheweb:fix/post-swap-complex-approvals
Sep 18, 2026
Merged

Aaronontheweb merged 2 commits into
netclaw-dev:devfrom
Aaronontheweb:fix/post-swap-complex-approvals

Conversation

@Aaronontheweb

Copy link
Copy Markdown
Collaborator

Problem

A sanitized Personal shell call had six complete parser commands. Two bare echo $? arguments caused a complex prompt and removed every reusable candidate.

Change

Shell analysis now accepts a bare $? data argument on a complete static output command without redirects.
The coordinator still checks every other verb and path through the normal approval gates.
Unknown positional parameters, redirects, substitutions, and unknown paths remain strict.

Verification

  • The prior analyzer build classified the live call as complex with zero candidates.
  • The new analyzer build classified the same call as complete with six candidates.
  • The replay parsed the call. It did not execute the command.
  • Security tests passed: 1,167 tests.
  • Actors tests passed: 4,021 tests. Six tests skipped under their existing conditions.
  • The focused shell mutation gate killed all 81 selected mutants across 17 targets. Both new mutants died.
  • Slopwatch found zero issues. Header checks and strict OpenSpec validation passed.

The headless model eval harness grants shell access. Actor and matcher tests exercise this approval gate directly.

@Aaronontheweb
Aaronontheweb enabled auto-merge (squash) September 18, 2026 21:30
@Aaronontheweb Aaronontheweb added bug Something isn't working security Security-related changes shell Issues related to the shell tool, since it has the largest security perimeter. tests All issues related to testing, quality assurance, and smoke testing. UX/DX UI / UX / DX friction issue or user-facing annoyances. labels Sep 18, 2026
@Aaronontheweb
Aaronontheweb merged commit 4864b80 into netclaw-dev:dev Sep 18, 2026
23 checks passed
@Aaronontheweb
Aaronontheweb deleted the fix/post-swap-complex-approvals branch September 21, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working security Security-related changes shell Issues related to the shell tool, since it has the largest security perimeter. tests All issues related to testing, quality assurance, and smoke testing. UX/DX UI / UX / DX friction issue or user-facing annoyances.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant