Conversation
Add application/vnd.openxmlformats-officedocument.presentationml.template to MimeTypeCatalog and MagicByteValidator so .potx uploads pass the ZIP-backed OOXML signature check. Fixes netclaw-dev#1459
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Register the PowerPoint template MIME type (
application/vnd.openxmlformats-officedocument.presentationml.template) so.potxuploads pass the content scanner instead of being rejected as unsupported.Motivation
Fixes #1459. The content scanner already accepts other ZIP-backed OOXML Office formats (e.g.
.pptx), but.potxtemplates were missing from the MIME catalog and magic-byte validator.Changes
.potxtoMimeTypeCatalogwith native ZIP signature validationIsZipmatcher inMagicByteValidator.potxinIsZipBackedOfficePathsoFileReadToolresolves the correct document MIME when magic bytes detect ZIPTests
dotnet test src/Netclaw.Media.Tests/Netclaw.Media.Tests.csproj— 66 passeddotnet test src/Netclaw.Security.Tests/Netclaw.Security.Tests.csproj— 1162 passedNotes
Scope is limited to
.potxas reported in the issue. Other OOXML template types (e.g..dotx,.xltx) can be added in follow-up PRs if needed.