Conversation
Fixes netclaw-dev#2084 Beta-channel installs pre-seed netclaw.json with only Daemon.UpdateChannel. Treat init as completed only when identity files, legacy personality files, or secrets.json exist, not merely when netclaw.json is present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Route
netclaw initto the first-run wizard when only a channel-seednetclaw.jsonexists (e.g. frominstall.sh --channel beta), instead of the existing-install action menu.Fixes #2084
Motivation
Non-stable installs pre-seed
~/.netclaw/config/netclaw.jsonwith onlyDaemon.UpdateChannel. The init route decision previously keyed offnetclaw.jsonexistence alone, so a fresh beta install incorrectly opened the "Existing Netclaw install detected" menu — a dead end for a box that never finished setup.Changes
NetclawPaths.HasCompletedSetup()— true when wizard-owned identity files (SOUL.md), legacy personality files (soul/PERSONALITY.md), orsecrets.jsonexistHasCompletedSetup()for init routing inProgram.csinstead ofFile.Exists(netclaw.json)init-existing.tapesmoke seed to includeSOUL.mdso the existing-install menu test remains validTests
dotnet test src/Netclaw.Configuration.Tests/Netclaw.Configuration.Tests.csproj --filter "FullyQualifiedName~HasCompletedSetup"— 3 passedPersonalityPathdetection added per review feedbackNotes
WizardConfigBuilder.PreserveExistingUpdateChannel()already preserves the installer channel seed through first-run init, so routing seed-only installs to/initis safe