fix: request JSON from OAuth token endpoints - #2167
Conversation
Aaronontheweb
left a comment
There was a problem hiding this comment.
The approach is sound. I found no defect in the changed code at revision 3dcf939d.
The handler adds Accept: application/json only to POST requests with form content. MCP JSON-RPC requests stay unchanged.
The programmable server returns form data without that header. The integration test proves that the production manager completes authorization with the header.
All code and platform checks passed. The required screenshot check remains red.
The first screenshot run found an unrelated MCP permissions-grid difference. The retry failed before execution because its attempt-specific binary artifact did not exist.
The stacked #2169 branch passed the same screenshot suite with this commit. This evidence points to the smoke workflow, not this OAuth change.
The PR needs a successful required check before merge. I did not perform a live GitHub authorization-code exchange.
Summary
Part of #2141. This PR covers token-response negotiation only. It does not add static client-secret configuration.
Target release: 0.27.0-beta.4.
Spike: https://github.com/Aaronontheweb/mcp-github-oauth-spike
Verification