Documented NetBird-Only Access and Proxy Cluster features in reverse …#767
Documented NetBird-Only Access and Proxy Cluster features in reverse …#767mlsmaycon wants to merge 4 commits into
Conversation
…proxy settings. Updated authentication methods, backend configuration guides, and cluster capability requirements.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
📝 WalkthroughWalkthroughDocumentation updates add NetBird-Only Access (private HTTP service auth), a Private cluster capability and Proxy Cluster target, UI and quick-start adjustments, automatic NetBird-range access rules and Direct Upstream behavior, and backend identity headers (X-NetBird-User, X-NetBird-Groups) with anti-spoof guidance. ChangesNetBird-Only Access for Private Services
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
src/pages/selfhosted/external-reverse-proxy.mdxOops! Something went wrong! :( ESLint: 9.39.4 TypeError: Converting circular structure to JSON src/pages/selfhosted/migration/enable-reverse-proxy.mdxOops! Something went wrong! :( ESLint: 9.39.4 TypeError: Converting circular structure to JSON Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/pages/manage/reverse-proxy/authentication.mdx`:
- Around line 278-279: Update the wording in the modal steps (the text
describing step 5 in authentication.mdx) to clarify that selected access groups
allow access not only to peers whose owning user is in those groups but also to
user-less peers that are members of those same peer groups (e.g., cluster
proxies); change the sentence that currently reads "Only peers whose owning user
is in one of these groups can reach the service" to include the caveat about
user-less peers and peer-group membership so the guidance is consistent with
earlier documentation.
In `@src/pages/manage/reverse-proxy/bring-your-own-proxy.mdx`:
- Line 208: Update the anchor in the link whose text is "**NetBird-Only
Access**" by replacing the incorrect slug
"`#net-bird-only-access-private-services`" with the exact heading slug used on the
target authentication page; locate the anchor in bring-your-own-proxy.mdx (the
Markdown link that currently contains "`#net-bird-only-access-private-services`")
and change it to the correct slug copied from the Authentication page's heading
so the in-page navigation works.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 79e4521e-93a0-46c2-b688-1cc8f32c359f
⛔ Files ignored due to path filters (5)
public/docs-static/img/manage/reverse-proxy/authentication/auth-netbird-only-modal.pngis excluded by!**/*.pngpublic/docs-static/img/manage/reverse-proxy/authentication/reverse-proxy-add-service-auth.pngis excluded by!**/*.pngpublic/docs-static/img/manage/reverse-proxy/byop/byop-clusters-private-feature.pngis excluded by!**/*.pngpublic/docs-static/img/manage/reverse-proxy/reverse-proxy-add-service-auth.pngis excluded by!**/*.pngpublic/docs-static/img/manage/reverse-proxy/reverse-proxy-add-target.pngis excluded by!**/*.png
📒 Files selected for processing (4)
src/pages/manage/reverse-proxy/authentication.mdxsrc/pages/manage/reverse-proxy/bring-your-own-proxy.mdxsrc/pages/manage/reverse-proxy/index.mdxsrc/pages/manage/reverse-proxy/service-configuration.mdx
…rol baseline behavior, added details on Direct Upstream and Proxy Cluster features, and refined cluster capability descriptions.
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/pages/manage/reverse-proxy/index.mdx (1)
252-252:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winBroken anchor in Private services link.
The heading in bring-your-own-proxy.mdx is "## Private services (NetBird-Only Access)" which generates
#private-services-netbird-only-access, but the link uses#private-services-net-bird-only-access(extra hyphen).-For **Proxy Cluster** targets, the host field accepts any hostname or IP the cluster's embedded proxy can resolve from its own host stack — see [Private services](/manage/reverse-proxy/bring-your-own-proxy#private-services-net-bird-only-access) for details. +For **Proxy Cluster** targets, the host field accepts any hostname or IP the cluster's embedded proxy can resolve from its own host stack — see [Private services](/manage/reverse-proxy/bring-your-own-proxy#private-services-netbird-only-access) for details.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/pages/manage/reverse-proxy/index.mdx` at line 252, The "Private services" anchor in the link is broken because the heading in bring-your-own-proxy.mdx is "## Private services (NetBird-Only Access)" which generates the slug "`#private-services-netbird-only-access`" but the current link uses "`#private-services-net-bird-only-access`"; update the link target in src/pages/manage/reverse-proxy/index.mdx (the link text "Private services") to use "`#private-services-netbird-only-access`" so it matches the generated heading slug.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@src/pages/manage/reverse-proxy/index.mdx`:
- Line 252: The "Private services" anchor in the link is broken because the
heading in bring-your-own-proxy.mdx is "## Private services (NetBird-Only
Access)" which generates the slug "`#private-services-netbird-only-access`" but
the current link uses "`#private-services-net-bird-only-access`"; update the link
target in src/pages/manage/reverse-proxy/index.mdx (the link text "Private
services") to use "`#private-services-netbird-only-access`" so it matches the
generated heading slug.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 08b02afa-89da-475b-a196-b59081f2beb5
⛔ Files ignored due to path filters (4)
public/docs-static/img/manage/reverse-proxy/byop/byop-clusters-private-feature.pngis excluded by!**/*.pngpublic/docs-static/img/manage/reverse-proxy/reverse-proxy-access-control-modal.pngis excluded by!**/*.pngpublic/docs-static/img/manage/reverse-proxy/reverse-proxy-add-service-settings.pngis excluded by!**/*.pngpublic/docs-static/img/manage/reverse-proxy/reverse-proxy-add-target.pngis excluded by!**/*.png
📒 Files selected for processing (3)
src/pages/manage/reverse-proxy/authentication.mdxsrc/pages/manage/reverse-proxy/bring-your-own-proxy.mdxsrc/pages/manage/reverse-proxy/index.mdx
…proxy settings. Updated authentication methods, backend configuration guides, and cluster capability requirements.
Summary by CodeRabbit