Repository navigation
feat(delivery): filter by failure reason and last status code - #17
Merged
kamilmysliwiec merged 2 commits intoOct 8, 2026
Merged
Conversation
Validate lastStatusCode in WebhookDeliveries.list() and retry(), so every store refuses a non-status value the same way. Add failureReason and lastStatusCode to WebhookDeliveryFilter, share the nullable integer comparison in the SQL stores, and document the filters' semantics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What is the current behavior?
WebhookDeliveries.list()cannot filter by a delivery鈥檚 storedfailureReasonorlastStatusCode.Issue Number: N/A
What is the new behavior?
Adds optional
failureReasonandlastStatusCodequery filters to the in-memory, PostgreSQL, and MySQL stores. Filters run before ordering and pagination. Omitting a filter matches any value; passingnullmatches stored null, solastStatusCode: nullfinds deliveries with no HTTP response.The shared store contract and public list tests cover these filters, their combination with existing filters, and null matching.
Does this PR introduce a breaking change?
Other information
No schema migration is needed because both values are already stored. API comments were updated. Focused tests and the TypeScript check passed.
The user-facing NestJS webhooks guide lives in a separate documentation repository and has not yet been updated.