Consume permanent action input errors and unbrick old tables - #451
Draft
nerdsane wants to merge 4 commits into
Draft
Consume permanent action input errors and unbrick old tables#451nerdsane wants to merge 4 commits into
nerdsane wants to merge 4 commits into
Conversation
Unknown bound CSDL actions now fail HTTP schema validation instead of Ok(()). Bundle lint requires an exact-name CSDL twin when the entity type is published. Older serialized tables stay readable but no longer skip actor requiredness when a live action lacks action_params. Nullable-parameter lint walks ActionTrigger.guard and Spawn.copy_fields.
SpecDrivenActor mapped MissingActionParameter to HandlerFailed, so activate() rolled back before cursor advance and retried the same row forever. Consume those permanent client errors instead. Old serialized tables omit action_params, so a missing key no longer fails every live rule. Parameterless hot-swapped tables can fire; required-param metadata still fails closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the two remaining FAILs on #450 (
c5d94fd) without reopening the four holds Rei already closed.Could not write to
nikstern/temper(codex/ioa-action-parameter-requiredness), so this branch starts at that PR head and adds one commit.FAIL-1 — SpecDrivenActor mailbox poison
validate_required_action_paramswas mapped toActorError::HandlerFailed.pg.rsactivate()returns beforeUPDATE_ACTOR, the tx rolls back, and the nextREAD_NEXT_MESSAGEis the same row. Permanent client input ({}, JSON null, or non-JSON →{}) retried forever.Fix: consume / dead-letter those permanent input errors (
Ok(())+ warn), matching EntityActorsuccess: false(message consumed).Test:
permanent_missing_action_parameter_does_not_remain_next_poll— fails onc5d94fd(HandlerFailed), passes here (cursor advances to the next row).FAIL-2 — old tables brick every live action
Missing
action_paramskey +rule_index.contains_key(action)always returnedMissingActionParameterwithparameter = action. Newly compiled parameterless actions haveaction_params[name] = []and passed; old serialized tables omit the key, so evenCancelOrderwith{}failed.Fix: a missing key on an old table does not brick parameterless actions. Required-param metadata still fails closed.
Tests:
older_serialized_table_parameterless_succeeds_required_still_fails_closedintemper-jitand EntityActorprocess_action. Parameterless old-table{}succeeds; required-param old-table{}is stillMissingActionParameter. Those assertions fail onc5d94fd.Still closed (do not reopen)
UnknownBoundAction;Directory.Createdoes not HTTP-skipcsdl_action_missingon published-entity exact-name missActionTrigger.guardandSpawn.copy_fieldsHead
2ed882bc31653d38797b2f47de5048f29220e228